From 6e5521595ddfcffd73ff54d1d14270e20f9e4e71 Mon Sep 17 00:00:00 2001
From: Elmar Kresse <elmar.kresse@stud.htwk-leipzig.de>
Date: Thu, 11 Apr 2024 09:24:56 +0200
Subject: [PATCH] fix:#57 fixed ss/ws check

---
 backend/service/fetch/v2/fetcher.go      | 59 +++++++++++++-----------
 backend/service/fetch/v2/fetcher_test.go | 39 ++++++++++++++++
 2 files changed, 71 insertions(+), 27 deletions(-)

diff --git a/backend/service/fetch/v2/fetcher.go b/backend/service/fetch/v2/fetcher.go
index 238c7a2..caee8ef 100644
--- a/backend/service/fetch/v2/fetcher.go
+++ b/backend/service/fetch/v2/fetcher.go
@@ -69,48 +69,53 @@ func FetchAllEventsAndSave(app *pocketbase.PocketBase, clock localTime.Clock) ([
 			"%0A?&template=sws_modul&weeks=1-65&combined=yes",
 	}
 
-	savedRecordsSs, errSs := fetchAndSaveAllEventsForSemester(app, time.March, time.October, "ss", clock, stubUrl)
-	if errSs == nil {
-		savedRecords = append(savedRecords, savedRecordsSs...)
-	}
-	savedRecordsWs, errWs := fetchAndSaveAllEventsForSemester(app, time.September, time.April, "ws", clock, stubUrl)
-	if errWs == nil {
-		savedRecords = append(savedRecords, savedRecordsWs...)
+	if isSummerSemester(clock) {
+		savedRecordsSs, errSs := fetchAndSaveAllEventsForSemester(app, "ss", stubUrl)
+		if errSs == nil {
+			savedRecords = append(savedRecords, savedRecordsSs...)
+		}
+	} else {
+		savedRecordsWs, errWs := fetchAndSaveAllEventsForSemester(app, "ws", stubUrl)
+		if errWs == nil {
+			savedRecords = append(savedRecords, savedRecordsWs...)
+		}
 	}
 	return savedRecords, err
 }
 
 func fetchAndSaveAllEventsForSemester(
 	app *pocketbase.PocketBase,
-	before time.Month,
-	after time.Month,
 	semester string,
-	clock localTime.Clock,
 	stubUrl [2]string,
 ) ([]model.Event, error) {
 	var err error = nil
 	var savedRecords []model.Event
-
-	if (clock.Now().Month() >= after) || (clock.Now().Month() <= before) {
-		url := stubUrl[0] + semester + stubUrl[1]
-		var events []model.Event
-		events, err = parseEventForOneSemester(url)
-		if err != nil {
-			return nil, fmt.Errorf("failed to parse events for "+semester+": %w", err)
-		}
-		err = db.DeleteAllEventsBySemesterWithoutCourse(app, "Sport", semester)
-		if err != nil {
-			return nil, fmt.Errorf("failed to delete all events for "+semester+": %w", err)
-		}
-		savedEvents, dbError := db.SaveEvents(events, app)
-		if dbError != nil {
-			return nil, fmt.Errorf("failed to save events for "+semester+": %w", dbError)
-		}
-		savedRecords = append(savedRecords, savedEvents...)
+	url := stubUrl[0] + semester + stubUrl[1]
+	var events []model.Event
+	events, err = parseEventForOneSemester(url)
+	if err != nil {
+		return nil, fmt.Errorf("failed to parse events for "+semester+": %w", err)
 	}
+	err = db.DeleteAllEventsBySemesterWithoutCourse(app, "Sport", semester)
+	if err != nil {
+		return nil, fmt.Errorf("failed to delete all events for "+semester+": %w", err)
+	}
+	savedEvents, dbError := db.SaveEvents(events, app)
+	if dbError != nil {
+		return nil, fmt.Errorf("failed to save events for "+semester+": %w", dbError)
+	}
+	savedRecords = append(savedRecords, savedEvents...)
 	return savedRecords, err
 }
 
+func isSummerSemester(clock localTime.Clock) bool {
+	if clock.Now().Month() >= time.April && clock.Now().Month() <= time.September {
+		return true
+	} else {
+		return false
+	}
+}
+
 func parseEventForOneSemester(url string) ([]model.Event, error) {
 	// Fetch Webpage from URL
 	webpage, err := fetch.GetHTML(url)
diff --git a/backend/service/fetch/v2/fetcher_test.go b/backend/service/fetch/v2/fetcher_test.go
index 9b2dec1..28eb103 100644
--- a/backend/service/fetch/v2/fetcher_test.go
+++ b/backend/service/fetch/v2/fetcher_test.go
@@ -18,8 +18,10 @@ package v2
 
 import (
 	"htwkalender/model"
+	mockTime "htwkalender/service/functions/time"
 	"reflect"
 	"testing"
+	"time"
 )
 
 func Test_switchNameAndNotesForExam(t *testing.T) {
@@ -97,3 +99,40 @@ func Test_switchNameAndNotesForExam(t *testing.T) {
 		})
 	}
 }
+
+func Test_isSummerSemester(t *testing.T) {
+	type args struct {
+		clock mockTime.MockClock
+	}
+	tests := []struct {
+		name string
+		args args
+		want bool
+	}{
+		{
+			name: "is summer semester",
+			args: args{
+				clock: mockTime.MockClock{
+					NowTime: time.Date(2024, 6, 1, 0, 0, 0, 0, time.UTC),
+				},
+			},
+			want: true,
+		},
+		{
+			name: "is not summer semester",
+			args: args{
+				clock: mockTime.MockClock{
+					NowTime: time.Date(2024, 1, 1, 0, 0, 0, 0, time.UTC),
+				},
+			},
+			want: false,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if got := isSummerSemester(tt.args.clock); got != tt.want {
+				t.Errorf("isSummerSemester() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}