From bfb05b6704f7751881cf6eccf3a8c496fc8f1554 Mon Sep 17 00:00:00 2001 From: Elmar Kresse Date: Mon, 24 Jun 2024 15:29:58 +0200 Subject: [PATCH] fix:#41 fixed naming issue sonarqube --- services/data-manager/main_test.go | 2 +- .../data-manager/model/eventModel_test.go | 16 +++++++-------- .../service/date/dateFormat_test.go | 2 +- .../data-manager/service/db/dbEvents_test.go | 2 +- .../service/events/courseService_test.go | 2 +- .../service/fetch/sport/sportFetcher_test.go | 2 +- .../fetch/v1/fetchSeminarEventService_test.go | 20 +++++++++---------- .../fetch/v1/fetchSeminarGroupService_test.go | 2 +- .../service/fetch/v2/fetcher_test.go | 2 +- .../service/functions/semester_test.go | 2 +- .../service/room/roomService_test.go | 6 +++--- .../ical/service/functions/semester_test.go | 2 +- 12 files changed, 30 insertions(+), 30 deletions(-) diff --git a/services/data-manager/main_test.go b/services/data-manager/main_test.go index 773d375..2275da5 100644 --- a/services/data-manager/main_test.go +++ b/services/data-manager/main_test.go @@ -20,7 +20,7 @@ import ( "testing" ) -func Test_setupApp(t *testing.T) { +func TestSetupApp(t *testing.T) { tests := []struct { name string }{ diff --git a/services/data-manager/model/eventModel_test.go b/services/data-manager/model/eventModel_test.go index c153f23..2749143 100644 --- a/services/data-manager/model/eventModel_test.go +++ b/services/data-manager/model/eventModel_test.go @@ -24,7 +24,7 @@ import ( "github.com/pocketbase/pocketbase/tools/types" ) -func TestEvents_Contains(t *testing.T) { +func TestEventsContains(t *testing.T) { specificTime, _ := types.ParseDateTime("2020-01-01 12:00:00.000Z") type args struct { @@ -70,7 +70,7 @@ func TestEvents_Contains(t *testing.T) { } } -func TestEvent_Equals(t *testing.T) { +func TestEventEquals(t *testing.T) { specificTime, _ := types.ParseDateTime("2020-01-01 12:00:00.000Z") type fields struct { @@ -148,7 +148,7 @@ func TestEvent_Equals(t *testing.T) { } } -func TestEvent_AnonymizeEvent(t *testing.T) { +func TestEventAnonymizeEvent(t *testing.T) { type fields struct { UUID string Day string @@ -218,7 +218,7 @@ func TestEvent_AnonymizeEvent(t *testing.T) { } } -func TestEvent_GetName(t *testing.T) { +func TestEventGetName(t *testing.T) { type fields struct { UUID string Day string @@ -278,7 +278,7 @@ func TestEvent_GetName(t *testing.T) { } } -func TestEvent_SetCourse(t *testing.T) { +func TestEventSetCourse(t *testing.T) { type fields struct { UUID string Day string @@ -338,7 +338,7 @@ func TestEvent_SetCourse(t *testing.T) { } } -func TestEvent_SetName(t *testing.T) { +func TestEventSetName(t *testing.T) { type fields struct { UUID string Day string @@ -398,7 +398,7 @@ func TestEvent_SetName(t *testing.T) { } } -func TestEvent_TableName(t *testing.T) { +func TestEventTableName(t *testing.T) { type fields struct { UUID string Day string @@ -453,7 +453,7 @@ func TestEvent_TableName(t *testing.T) { } } -func TestEvents_Contains1(t *testing.T) { +func TestEventsContains1(t *testing.T) { type args struct { event Event } diff --git a/services/data-manager/service/date/dateFormat_test.go b/services/data-manager/service/date/dateFormat_test.go index 4ab97be..f43a77b 100644 --- a/services/data-manager/service/date/dateFormat_test.go +++ b/services/data-manager/service/date/dateFormat_test.go @@ -23,7 +23,7 @@ import ( _ "time/tzdata" ) -func Test_getDateFromWeekNumber(t *testing.T) { +func TestGetDateFromWeekNumber(t *testing.T) { europeTime, _ := time.LoadLocation("Europe/Berlin") type args struct { diff --git a/services/data-manager/service/db/dbEvents_test.go b/services/data-manager/service/db/dbEvents_test.go index 8708394..7347062 100644 --- a/services/data-manager/service/db/dbEvents_test.go +++ b/services/data-manager/service/db/dbEvents_test.go @@ -22,7 +22,7 @@ import ( "testing" ) -func Test_buildIcalQueryForModules(t *testing.T) { +func TestBuildIcalQueryForModules(t *testing.T) { type args struct { modules []string } diff --git a/services/data-manager/service/events/courseService_test.go b/services/data-manager/service/events/courseService_test.go index 3d5e033..724f0d1 100644 --- a/services/data-manager/service/events/courseService_test.go +++ b/services/data-manager/service/events/courseService_test.go @@ -21,7 +21,7 @@ import ( "testing" ) -func Test_removeEmptyCourses(t *testing.T) { +func TestRemoveEmptyCourses(t *testing.T) { type args struct { courses []string } diff --git a/services/data-manager/service/fetch/sport/sportFetcher_test.go b/services/data-manager/service/fetch/sport/sportFetcher_test.go index 0f4c06d..bd0d512 100644 --- a/services/data-manager/service/fetch/sport/sportFetcher_test.go +++ b/services/data-manager/service/fetch/sport/sportFetcher_test.go @@ -21,7 +21,7 @@ import ( "testing" ) -func Test_splitByCommaWithTime(t *testing.T) { +func TestSplitByCommaWithTime(t *testing.T) { type args struct { input string } diff --git a/services/data-manager/service/fetch/v1/fetchSeminarEventService_test.go b/services/data-manager/service/fetch/v1/fetchSeminarEventService_test.go index 8398adb..f625705 100644 --- a/services/data-manager/service/fetch/v1/fetchSeminarEventService_test.go +++ b/services/data-manager/service/fetch/v1/fetchSeminarEventService_test.go @@ -25,7 +25,7 @@ import ( "time" ) -func Test_extractSemesterAndYear(t *testing.T) { +func TestExtractSemesterAndYear(t *testing.T) { type args struct { semesterString string } @@ -73,7 +73,7 @@ func Test_extractSemesterAndYear(t *testing.T) { } } -func Test_replaceEmptyEventNames(t *testing.T) { +func TestReplaceEmptyEventNames(t *testing.T) { type args struct { group model.SeminarGroup } @@ -130,7 +130,7 @@ func Test_replaceEmptyEventNames(t *testing.T) { } } -func Test_splitEventType(t *testing.T) { +func TestSplitEventType(t *testing.T) { type args struct { events []model.Event } @@ -220,7 +220,7 @@ func Test_splitEventType(t *testing.T) { } } -func Test_generateUUIDs(t *testing.T) { +func TestGenerateUUIDs(t *testing.T) { type args struct { events []model.Event course string @@ -274,7 +274,7 @@ func Test_generateUUIDs(t *testing.T) { } } -func Test_createTimeFromHourAndMinuteString(t *testing.T) { +func TestCreateTimeFromHourAndMinuteString(t *testing.T) { type args struct { tableTime string } @@ -314,7 +314,7 @@ func Test_createTimeFromHourAndMinuteString(t *testing.T) { } } -func Test_replaceTimeInDate(t *testing.T) { +func TestReplaceTimeInDate(t *testing.T) { type args struct { date time.Time time time.Time @@ -350,7 +350,7 @@ func Test_replaceTimeInDate(t *testing.T) { } } -func Test_convertWeeksToDates(t *testing.T) { +func TestConvertWeeksToDates(t *testing.T) { type args struct { events []model.Event semester string @@ -450,7 +450,7 @@ func Test_convertWeeksToDates(t *testing.T) { } } -func Test_replaceTimeForDate(t *testing.T) { +func TestReplaceTimeForDate(t *testing.T) { type args struct { date time.Time replacementTime time.Time @@ -502,7 +502,7 @@ func Test_replaceTimeForDate(t *testing.T) { } } -func Test_isSummerSemester(t *testing.T) { +func TestIsSummerSemester(t *testing.T) { type args struct { month time.Month } @@ -535,7 +535,7 @@ func Test_isSummerSemester(t *testing.T) { } } -func Test_isWinterSemester(t *testing.T) { +func TestIsWinterSemester(t *testing.T) { type args struct { month time.Month } diff --git a/services/data-manager/service/fetch/v1/fetchSeminarGroupService_test.go b/services/data-manager/service/fetch/v1/fetchSeminarGroupService_test.go index 6c2cfbe..f75c3a0 100644 --- a/services/data-manager/service/fetch/v1/fetchSeminarGroupService_test.go +++ b/services/data-manager/service/fetch/v1/fetchSeminarGroupService_test.go @@ -21,7 +21,7 @@ import ( "testing" ) -func Test_contains(t *testing.T) { +func TestContains(t *testing.T) { type args struct { groups []model.SeminarGroup group model.SeminarGroup diff --git a/services/data-manager/service/fetch/v2/fetcher_test.go b/services/data-manager/service/fetch/v2/fetcher_test.go index 0a3e2ad..a9f901a 100644 --- a/services/data-manager/service/fetch/v2/fetcher_test.go +++ b/services/data-manager/service/fetch/v2/fetcher_test.go @@ -22,7 +22,7 @@ import ( "testing" ) -func Test_switchNameAndNotesForExam(t *testing.T) { +func TestSwitchNameAndNotesForExam(t *testing.T) { type args struct { events []model.Event } diff --git a/services/data-manager/service/functions/semester_test.go b/services/data-manager/service/functions/semester_test.go index 35a8f9c..d075825 100644 --- a/services/data-manager/service/functions/semester_test.go +++ b/services/data-manager/service/functions/semester_test.go @@ -7,7 +7,7 @@ import ( "time" ) -func Test_calculateSemesterList(t *testing.T) { +func TestCalculateSemesterList(t *testing.T) { type args struct { clock mockTime.Clock } diff --git a/services/data-manager/service/room/roomService_test.go b/services/data-manager/service/room/roomService_test.go index b4bf733..3cade0e 100644 --- a/services/data-manager/service/room/roomService_test.go +++ b/services/data-manager/service/room/roomService_test.go @@ -23,7 +23,7 @@ import ( "testing" ) -func Test_anonymizeRooms(t *testing.T) { +func TestAnonymizeRooms(t *testing.T) { type args struct { events []model.Event } @@ -139,7 +139,7 @@ func Test_anonymizeRooms(t *testing.T) { } } -func Test_isRoomInSchedule(t *testing.T) { +func TestIsRoomInSchedule(t *testing.T) { type args struct { room string schedule []model.Event @@ -245,7 +245,7 @@ func Test_isRoomInSchedule(t *testing.T) { } } -func Test_getFreeRooms(t *testing.T) { +func TestGetFreeRooms(t *testing.T) { type args struct { rooms []string schedule []model.Event diff --git a/services/ical/service/functions/semester_test.go b/services/ical/service/functions/semester_test.go index 0f46f11..9595ede 100644 --- a/services/ical/service/functions/semester_test.go +++ b/services/ical/service/functions/semester_test.go @@ -7,7 +7,7 @@ import ( "time" ) -func Test_calculateSemesterList(t *testing.T) { +func TestCalculateSemesterList(t *testing.T) { type args struct { clock mockTime.Clock }