From 006c794f54382eddca6263d3127fd80faaa7f696 Mon Sep 17 00:00:00 2001
From: Sebastian Serth <Sebastian.Serth@hpi.de>
Date: Wed, 14 Sep 2022 00:31:47 +0200
Subject: [PATCH] Fix rubocop offenses

---
 spec/concerns/lti_spec.rb                         | 14 +++++++-------
 spec/features/request_for_comments_filter_spec.rb |  2 +-
 spec/lib/testing_framework_adapter_spec.rb        |  1 +
 3 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/spec/concerns/lti_spec.rb b/spec/concerns/lti_spec.rb
index 8da3aebb..42ede17d 100644
--- a/spec/concerns/lti_spec.rb
+++ b/spec/concerns/lti_spec.rb
@@ -130,6 +130,7 @@ describe Lti do
 
         context 'when grading is supported' do
           let(:response) { double }
+          let(:send_score) { controller.send(:send_score, submission) }
 
           before do
             allow_any_instance_of(IMS::LTI::ToolProvider).to receive(:outcome_service?).and_return(true)
@@ -138,19 +139,18 @@ describe Lti do
             allow(response).to receive(:post_response).and_return(response)
             allow(response).to receive(:body).at_least(:once).and_return('')
             allow(response).to receive(:code_major).at_least(:once).and_return('success')
+            allow(submission).to receive(:normalized_score).and_return score
           end
 
           it 'sends the score' do
-            allow(submission).to receive(:normalized_score).and_return score
-            controller.send(:send_score, submission)
+            expect_any_instance_of(IMS::LTI::ToolProvider).to receive(:post_replace_result!).with(score)
+            send_score
           end
 
           it 'returns code, message, and status' do
-            allow(submission).to receive(:normalized_score).and_return score
-            result = controller.send(:send_score, submission)
-            expect(result[:code]).to eq(response.response_code)
-            expect(result[:message]).to eq(response.body)
-            expect(result[:status]).to eq(response.code_major)
+            expect(send_score[:code]).to eq(response.response_code)
+            expect(send_score[:message]).to eq(response.body)
+            expect(send_score[:status]).to eq(response.code_major)
           end
         end
       end
diff --git a/spec/features/request_for_comments_filter_spec.rb b/spec/features/request_for_comments_filter_spec.rb
index 17eadacb..a3362a5e 100644
--- a/spec/features/request_for_comments_filter_spec.rb
+++ b/spec/features/request_for_comments_filter_spec.rb
@@ -29,6 +29,6 @@ describe 'Request_for_Comments' do
 
   it 'contains a filter for study group in the view' do
     visit(request_for_comments_path)
-    expect(page.find('#q_submission_study_group_id_in')).not_to be_nil
+    expect(page.find_by_id('q_submission_study_group_id_in')).not_to be_nil # rubocop:disable Rails/DynamicFindBy
   end
 end
diff --git a/spec/lib/testing_framework_adapter_spec.rb b/spec/lib/testing_framework_adapter_spec.rb
index cefb9868..78cd36e9 100644
--- a/spec/lib/testing_framework_adapter_spec.rb
+++ b/spec/lib/testing_framework_adapter_spec.rb
@@ -43,6 +43,7 @@ describe TestingFrameworkAdapter do
   describe '#test_outcome' do
     it 'calls the framework-specific implementation' do
       allow(adapter).to receive(:parse_output).and_return(count: count, failed: failed, passed: passed)
+      expect(adapter).to receive(:parse_output)
       adapter.test_outcome('')
     end
   end