Use author_in_programming_group? policy for files & RfCs

* Allow all members of a programming group to list and solve RfCs
* Also adjust policy specs to respect programming groups
This commit is contained in:
kiragrammel
2023-08-22 09:23:20 +02:00
committed by Sebastian Serth
parent 9d1be1eeff
commit 01accdae58
7 changed files with 101 additions and 19 deletions

View File

@ -59,6 +59,12 @@ describe RequestForCommentPolicy do
it 'grants access to authors' do
expect(policy).to permit(rfc.author, rfc)
end
it 'grant access to other authors of the programming group' do
rfc.submission.update(contributor: programming_group)
expect(policy).to permit(author_other_group_member, rfc)
expect(policy).to permit(viewer_other_group_member, rfc)
end
end
shared_examples 'grants access to admins and authors only' do
@ -70,6 +76,12 @@ describe RequestForCommentPolicy do
expect(policy).to permit(rfc.author, rfc)
end
it 'grant access to other authors of the programming group' do
rfc.submission.update(contributor: programming_group)
expect(policy).to permit(author_other_group_member, rfc)
expect(policy).to permit(viewer_other_group_member, rfc)
end
it 'does not grant access to all other users' do
%i[external_user teacher].each do |factory_name|
expect(policy).not_to permit(create(factory_name, consumer: viewer_consumer, study_groups: viewer_study_groups), rfc)
@ -81,6 +93,10 @@ describe RequestForCommentPolicy do
let(:author_study_groups) { create_list(:study_group, 1, consumer: author_consumer) }
let(:rfc) { create(:rfc, user: rfc_author) }
let(:author_other_group_member) { create(:external_user, consumer: author_consumer) }
let(:viewer_other_group_member) { create(:external_user, consumer: viewer_consumer) }
let(:programming_group) { create(:programming_group, exercise: rfc.submission.exercise, users: [rfc.author, author_other_group_member, viewer_other_group_member]) }
context "when the author's rfc_visibility is set to all" do
let(:author_consumer) { create(:consumer, rfc_visibility: 'all') }