From 06928340c9950bec60220fc2041d2410212a8e20 Mon Sep 17 00:00:00 2001
From: Maximilian Grundke <maximiliangrundke@googlemail.com>
Date: Sun, 4 Feb 2018 16:27:11 +0100
Subject: [PATCH] Extract last submission per user to Exercise model

---
 app/models/exercise.rb                   | 10 ++++++++++
 lib/tasks/detect_exercise_anomalies.rake | 17 ++++-------------
 2 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/app/models/exercise.rb b/app/models/exercise.rb
index f03d6641..7902b088 100644
--- a/app/models/exercise.rb
+++ b/app/models/exercise.rb
@@ -368,4 +368,14 @@ class Exercise < ActiveRecord::Base
     user_exercise_feedbacks.size <= MAX_EXERCISE_FEEDBACKS
   end
 
+  def last_submission_per_user
+    Submission.joins("JOIN (
+          SELECT
+              user_id,
+              first_value(id) OVER (PARTITION BY user_id ORDER BY created_at DESC) AS fv
+          FROM submissions
+          WHERE exercise_id = #{id}
+        ) AS t ON t.fv = submissions.id").distinct
+  end
+
 end
diff --git a/lib/tasks/detect_exercise_anomalies.rake b/lib/tasks/detect_exercise_anomalies.rake
index f8e5bc2a..e9532bcc 100644
--- a/lib/tasks/detect_exercise_anomalies.rake
+++ b/lib/tasks/detect_exercise_anomalies.rake
@@ -76,19 +76,10 @@ namespace :detect_exercise_anomalies do
   def notify_users(collection, anomalies)
     puts "\t\tSending E-Mails to best and worst performing users of each anomaly..."
     anomalies.each do |exercise_id, average_working_time|
-      submissions = Submission.find_by_sql(['
-            select distinct s.*
-            from
-              (
-                select
-                    user_id,
-                    first_value(id) over (partition by user_id order by created_at desc) as fv
-                from submissions
-                where exercise_id = ?
-              ) as t
-              join submissions s on s.id = t.fv
-            where score is not null
-            order by score', exercise_id])
+      submissions = Exercise.find(exercise_id)
+                        .last_submission_per_user
+                        .where('score is not null')
+                        .order(:score)
       best_performers = submissions.first(10).to_a.map do |item|
         item.user_id
       end