htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Destroy runner at management in case of errors

Browse Source
This commit is contained in:
Sebastian Serth
2021-10-11 15:19:23 +02:00
parent 7e7b7ebdfa
commit 08f36a0a7a
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/runner/connection.rb
View File

@ -113,15 +113,23 @@ class Runner::Connection
def on_close(_event) def on_close(_event)
Rails.logger.debug { "#{Time.zone.now.getutc}: Closing connection to #{@socket.url} with status: #{@status}" } Rails.logger.debug { "#{Time.zone.now.getutc}: Closing connection to #{@socket.url} with status: #{@status}" }
forward_message @buffer.flush forward_message @buffer.flush
# Depending on the status, we might want to destroy the runner at management.
# This ensures we get a new runner on the next request.
# All failing runs, those cancelled by the user or those hitting a timeout or error are subject to this mechanism.
case @status case @status
when :timeout when :timeout
@strategy.destroy_at_management
@error = Runner::Error::ExecutionTimeout.new('Execution exceeded its time limit') @error = Runner::Error::ExecutionTimeout.new('Execution exceeded its time limit')
when :terminated_by_codeocean, :terminated_by_management when :terminated_by_codeocean, :terminated_by_management
@exit_callback.call @exit_code @exit_callback.call @exit_code
when :terminated_by_client, :error when :terminated_by_client, :error
@strategy.destroy_at_management
else # :established else # :established
# If the runner is killed by the DockerContainerPool after the maximum allowed time per user and # If the runner is killed by the DockerContainerPool after the maximum allowed time per user and
# while the owning user is running an execution, the command execution stops and log output is incomplete. # while the owning user is running an execution, the command execution stops and log output is incomplete.
@strategy.destroy_at_management
@error = Runner::Error::Unknown.new('Execution terminated with an unknown reason') @error = Runner::Error::Unknown.new('Execution terminated with an unknown reason')
end end
@event_loop.stop @event_loop.stop