htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Preload error template attributes in SubmissionsController

Browse Source 
The join operation is okay, since a similar one is otherwise performed automatically by Rails
This commit is contained in:
Sebastian Serth
2023-03-20 23:52:34 +01:00
parent e3e6fc3af1
commit 09809cc12e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/submissions_controller.rb
View File

@ -353,7 +353,7 @@ class SubmissionsController < ApplicationController
def extract_errors def extract_errors
results = [] results = []
if @testrun[:output].present? if @testrun[:output].present?
@submission.exercise.execution_environment.error_templates.each do |template| @submission.exercise.execution_environment.error_templates.left_joins(:error_template_attributes).includes(:error_template_attributes).each do |template|
pattern = Regexp.new(template.signature).freeze pattern = Regexp.new(template.signature).freeze
results << StructuredError.create_from_template(template, @testrun[:output], @submission) if pattern.match(@testrun[:output]) results << StructuredError.create_from_template(template, @testrun[:output], @submission) if pattern.match(@testrun[:output])
end end