From 0988e41f6d52f4b7c74e22e7db906b6cfe8e8a12 Mon Sep 17 00:00:00 2001 From: Sebastian Serth Date: Sun, 25 Oct 2020 16:09:51 +0100 Subject: [PATCH] Use Conccurrent::Future properly --- app/controllers/concerns/submission_scoring.rb | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/app/controllers/concerns/submission_scoring.rb b/app/controllers/concerns/submission_scoring.rb index 4fc8d737..95d2393a 100644 --- a/app/controllers/concerns/submission_scoring.rb +++ b/app/controllers/concerns/submission_scoring.rb @@ -3,8 +3,8 @@ require 'concurrent/future' module SubmissionScoring def collect_test_results(submission) # Mnemosyne.trace 'custom.codeocean.collect_test_results', meta: { submission: submission.id } do - submission.collect_files.select(&:teacher_defined_assessment?).map do |file| - future = Concurrent::Future.execute do + futures = submission.collect_files.select(&:teacher_defined_assessment?).map do |file| + Concurrent::Future.execute do # Mnemosyne.trace 'custom.codeocean.collect_test_results_block', meta: { file: file.id, submission: submission.id } do assessor = Assessor.new(execution_environment: submission.execution_environment) output = execute_test_file(file, submission) @@ -32,9 +32,8 @@ module SubmissionScoring output.merge!(filename: file.name_with_extension, message: feedback_message(file, output), weight: file.weight) # end end - future.value end - # end + futures.map(&:value) end private :collect_test_results