Memoize collect_files

2021-11-02 16:19:01 +01:00
parent e37683a1b2
commit 0b4217b12d
1 changed files with 5 additions and 3 deletions
--- a/app/models/submission.rb
+++ b/app/models/submission.rb
@ -56,9 +56,11 @@ class Submission < ApplicationRecord
  private :build_files_hash

  def collect_files
-    ancestors = build_files_hash(exercise.files.includes(:file_type), :id)
-    descendants = build_files_hash(files.includes(:file_type), :file_id)
-    ancestors.merge(descendants).values
+    @collect_files ||= begin
+      ancestors = build_files_hash(exercise.files.includes(:file_type), :id)
+      descendants = build_files_hash(files.includes(:file_type), :file_id)
+      ancestors.merge(descendants).values
+    end
  end

  def main_file