From 0bd7c93d65a01d3cc65625a24fbd09639bdf8d84 Mon Sep 17 00:00:00 2001 From: Sebastian Serth Date: Fri, 24 Nov 2023 16:41:49 +0100 Subject: [PATCH] Allow clicking on checkboxes for batch update --- Gemfile.lock | 12 ++++++------ app/assets/javascripts/exercises.js.erb | 4 ++++ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 704f91c8..47c7e26d 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -314,18 +314,18 @@ GEM pundit (2.3.1) activesupport (>= 3.0.0) racc (1.7.3) - rack (3.0.8) + rack (2.2.8) rack-mini-profiler (3.1.1) rack (>= 1.2.0) rack-proxy (0.7.7) rack - rack-session (2.0.0) - rack (>= 3.0.0) + rack-session (1.0.1) + rack (< 3) rack-test (2.1.0) rack (>= 1.3) - rackup (2.1.0) - rack (>= 3) - webrick (~> 1.8) + rackup (1.0.0) + rack (< 3) + webrick rails (7.1.2) actioncable (= 7.1.2) actionmailbox (= 7.1.2) diff --git a/app/assets/javascripts/exercises.js.erb b/app/assets/javascripts/exercises.js.erb index e6130964..9b0b185a 100644 --- a/app/assets/javascripts/exercises.js.erb +++ b/app/assets/javascripts/exercises.js.erb @@ -134,6 +134,10 @@ $(document).on('turbolinks:load', function () { class: 'form-check-input', }); td.on('click', function (event) { + if (event.target !== this) { + // We don't want to trigger the handler when clicking directly on the checkbox. + return; + } event.preventDefault(); checkbox.prop('checked', !checkbox.prop('checked')); });