htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rename factory_girl_(rails) to factory_bot_(rails)

Browse Source
This commit is contained in:
Ralf Teusner
2017-11-15 15:18:07 +01:00
parent 951b71780c
commit 0e26ab98c8
68 changed files with 253 additions and 253 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
spec/models/submission_spec.rb
View File

@ -1,7 +1,7 @@
require 'rails_helper'
describe Submission do
let(:submission) { FactoryGirl.create(:submission, exercise: FactoryGirl.create(:dummy)) }
let(:submission) { FactoryBot.create(:submission, exercise: FactoryGirl.create(:dummy)) }
it 'validates the presence of a cause' do
expect(described_class.create.errors[:cause]).to be_present
@ -17,7 +17,7 @@ describe Submission do
end
describe '#main_file' do
let(:submission) { FactoryGirl.create(:submission) }
let(:submission) { FactoryBot.create(:submission) }
it "returns the submission's main file" do
expect(submission.main_file).to be_a(CodeOcean::File)
@ -27,7 +27,7 @@ describe Submission do
describe '#normalized_score' do
context 'with a score' do
let(:submission) { FactoryGirl.create(:submission) }
let(:submission) { FactoryBot.create(:submission) }
before(:each) { submission.score = submission.exercise.maximum_score / 2 }
it 'returns the score as a value between 0 and 1' do
@ -46,7 +46,7 @@ describe Submission do
describe '#percentage' do
context 'with a score' do
let(:submission) { FactoryGirl.create(:submission) }
let(:submission) { FactoryBot.create(:submission) }
before(:each) { submission.score = submission.exercise.maximum_score / 2 }
it 'returns the score expressed as a percentage' do
@ -65,11 +65,11 @@ describe Submission do
describe '#siblings' do
let(:siblings) { described_class.find_by(user: user).siblings }
let(:user) { FactoryGirl.create(:external_user) }
let(:user) { FactoryBot.create(:external_user) }
before(:each) do
10.times.each_with_index do |_, index|
FactoryGirl.create(:submission, exercise: submission.exercise, user: (index.even? ? user : FactoryGirl.create(:external_user)))
FactoryBot.create(:submission, exercise: submission.exercise, user: (index.even? ? user : FactoryGirl.create(:external_user)))
end
end
@ -89,9 +89,9 @@ describe Submission do
describe '#redirect_to_feedback?' do
context 'with no exercise feedback' do
let(:exercise) {FactoryGirl.create(:dummy)}
let(:user) {FactoryGirl.build(:external_user, id: (11 - exercise.created_at.to_i % 10) % 10)}
let(:submission) {FactoryGirl.build(:submission, exercise: exercise, user: user)}
let(:exercise) {FactoryBot.create(:dummy)}
let(:user) {FactoryBot.build(:external_user, id: (11 - exercise.created_at.to_i % 10) % 10)}
let(:submission) {FactoryBot.build(:submission, exercise: exercise, user: user)}
it 'sends 10% of users to feedback page' do
expect(submission.send(:redirect_to_feedback?)).to be_truthy
@ -99,16 +99,16 @@ describe Submission do
it 'does not redirect other users' do
9.times do |i|
submission = FactoryGirl.build(:submission, exercise: exercise, user: FactoryGirl.build(:external_user, id: (11 - exercise.created_at.to_i % 10) - i - 1))
submission = FactoryBot.build(:submission, exercise: exercise, user: FactoryGirl.build(:external_user, id: (11 - exercise.created_at.to_i % 10) - i - 1))
expect(submission.send(:redirect_to_feedback?)).to be_falsey
end
end
end
context 'with little exercise feedback' do
let(:exercise) {FactoryGirl.create(:dummy_with_user_feedbacks)}
let(:user) {FactoryGirl.build(:external_user, id: (11 - exercise.created_at.to_i % 10) % 10)}
let(:submission) {FactoryGirl.build(:submission, exercise: exercise, user: user)}
let(:exercise) {FactoryBot.create(:dummy_with_user_feedbacks)}
let(:user) {FactoryBot.build(:external_user, id: (11 - exercise.created_at.to_i % 10) % 10)}
let(:submission) {FactoryBot.build(:submission, exercise: exercise, user: user)}
it 'sends 10% of users to feedback page' do
expect(submission.send(:redirect_to_feedback?)).to be_truthy
@ -116,19 +116,19 @@ describe Submission do
it 'does not redirect other users' do
9.times do |i|
submission = FactoryGirl.build(:submission, exercise: exercise, user: FactoryGirl.build(:external_user, id: (11 - exercise.created_at.to_i % 10) - i - 1))
submission = FactoryBot.build(:submission, exercise: exercise, user: FactoryGirl.build(:external_user, id: (11 - exercise.created_at.to_i % 10) - i - 1))
expect(submission.send(:redirect_to_feedback?)).to be_falsey
end
end
end
context 'with enough exercise feedback' do
let(:exercise) {FactoryGirl.create(:dummy_with_user_feedbacks, user_feedbacks_count: 42)}
let(:user) {FactoryGirl.create(:external_user)}
let(:exercise) {FactoryBot.create(:dummy_with_user_feedbacks, user_feedbacks_count: 42)}
let(:user) {FactoryBot.create(:external_user)}
it 'sends nobody to feedback page' do
30.times do |i|
submission = FactoryGirl.create(:submission, exercise: exercise, user: FactoryGirl.create(:external_user))
submission = FactoryBot.create(:submission, exercise: exercise, user: FactoryGirl.create(:external_user))
expect(submission.send(:redirect_to_feedback?)).to be_falsey
end
end