htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor various ruby files

Browse Source 
* Insights based on brakeman report
This commit is contained in:
Sebastian Serth
2022-08-18 15:06:36 +02:00
parent 1560f6b316
commit 145c4aa8d5
35 changed files with 113 additions and 107 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/controllers/study_groups_controller.rb
View File

@ -23,7 +23,7 @@ class StudyGroupsController < ApplicationController
def update
myparams = study_group_params
myparams[:external_users] =
StudyGroupMembership.find(myparams[:study_group_membership_ids].compact_blank).map(&:user)
StudyGroupMembership.find_by(id: myparams[:study_group_membership_ids].compact_blank).map(&:user)
myparams.delete(:study_group_membership_ids)
update_and_respond(object: @study_group, params: myparams)
end
@ -38,7 +38,7 @@ class StudyGroupsController < ApplicationController
private :study_group_params
def set_group
@study_group = StudyGroup.find(params[:id])
@study_group = StudyGroup.find_by(id: params[:id])
authorize!
end
private :set_group