Refactor various ruby files

* Insights based on brakeman report
2022-08-18 15:06:36 +02:00
parent 1560f6b316
commit 145c4aa8d5
35 changed files with 113 additions and 107 deletions
--- a/app/controllers/subscriptions_controller.rb
+++ b/app/controllers/subscriptions_controller.rb
@ -22,7 +22,7 @@ class SubscriptionsController < ApplicationController
  # DELETE /subscriptions/1
  # DELETE /subscriptions/1.json
  def destroy
-    @subscription = Subscription.find(params[:id])
+    @subscription = Subscription.find_by(id: params[:id])
  rescue StandardError
    skip_authorization
    respond_to do |format|
@ -47,7 +47,7 @@ class SubscriptionsController < ApplicationController
  end

  def set_subscription
-    @subscription = Subscription.find(params[:id])
+    @subscription = Subscription.find_by(id: params[:id])
    authorize!
  end
  private :set_subscription