Refactor various ruby files
* Insights based on brakeman report
This commit is contained in:
@ -1,4 +1,5 @@
|
||||
- if model = Kernel.const_get(controller_path.classify) rescue nil
|
||||
- model = controller_path.classify.constantize rescue nil
|
||||
- if model
|
||||
- object = model.find_by(id: params[:id])
|
||||
- if model.try(:nested_resource?)
|
||||
- root_element = model.model_name.human(count: 2)
|
||||
|
@ -4,4 +4,4 @@ li.nav-item.dropdown
|
||||
span.caret
|
||||
ul.dropdown-menu.p-0.mt-1 role='menu'
|
||||
- I18n.available_locales.sort_by { |locale| t("locales.#{locale}") }.each do |locale|
|
||||
li = link_to(t("locales.#{locale}"), url_for(params.permit!.merge(locale: locale)), 'data-turbolinks' => "false", class: 'dropdown-item')
|
||||
li = link_to(t("locales.#{locale}"), url_for(request.query_parameters.merge(locale: locale)), 'data-turbolinks' => "false", class: 'dropdown-item')
|
||||
|
@ -1,9 +1,11 @@
|
||||
h1 = t('.headline')
|
||||
|
||||
- consumer = @submission.user.consumer
|
||||
|
||||
p
|
||||
== t(".success_#{params[:outcome] ? 'with' : 'without'}_outcome", consumer: @consumer)
|
||||
==< t(".finished_#{@consumer ? 'with' : 'without'}_consumer", consumer: @consumer, url: params[:url])
|
||||
==< t(".do_not_use_backbutton", consumer: @consumer)
|
||||
= t(".success_#{consumer ? 'with' : 'without'}_outcome", consumer: consumer)
|
||||
==< t(".finished_#{consumer ? 'with' : 'without'}_consumer", consumer: h(consumer.name), url: @url)
|
||||
=< t(".do_not_use_backbutton")
|
||||
|
||||
h2 = t('shared.statistics')
|
||||
|
||||
|
Reference in New Issue
Block a user