htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Switch order of unloading the autosave timer

Browse Source 
Hypothesis: When unloadAutoSave was called, we first saved (causing this.autosaveTimer to become null) and then tried to clearTimeout on this variable (= on null). This probably never worked?

Hopefully closes CODEOCEAN-B5
This commit is contained in:
Sebastian Serth
2022-11-16 23:26:25 +01:00
parent 591f776f69
commit 15878f500c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/editor/submissions.js
View File

@ -76,7 +76,7 @@ CodeOceanEditorSubmissions = {
if (file_id_old != null && data.files){ if (file_id_old != null && data.files){
// if we find file_id_old (this is the reference to the base file) in the submission, this is the match // if we find file_id_old (this is the reference to the base file) in the submission, this is the match
for(var j = 0; j< data.files.length; j++){ for(var j = 0; j< data.files.length; j++){
if(data.files[j].file_id == file_id_old){ if(data.files[j].file_id === file_id_old){
//$(editors[i].container).data('id') = data.files[j].id; //$(editors[i].container).data('id') = data.files[j].id;
$(this.editors[i].container).data('id', data.files[j].id ); $(this.editors[i].container).data('id', data.files[j].id );
} }
@ -230,8 +230,8 @@ CodeOceanEditorSubmissions = {
unloadAutoSave: function() { unloadAutoSave: function() {
if(this.autosaveTimer != null){ if(this.autosaveTimer != null){
this.autosave();
clearTimeout(this.autosaveTimer); clearTimeout(this.autosaveTimer);
this.autosave();
} }
}, },