From 174db96081844db3303f3a2d9cc0c2e6d4f5438a Mon Sep 17 00:00:00 2001 From: Maximilian Grundke Date: Fri, 5 Oct 2018 14:55:22 +0200 Subject: [PATCH] Move magic number to config instead --- app/assets/javascripts/editor/participantsupport.js.erb | 7 ++++--- config/code_ocean.yml.example | 2 ++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/app/assets/javascripts/editor/participantsupport.js.erb b/app/assets/javascripts/editor/participantsupport.js.erb index 8bc68fdd..e3f81aad 100644 --- a/app/assets/javascripts/editor/participantsupport.js.erb +++ b/app/assets/javascripts/editor/participantsupport.js.erb @@ -26,12 +26,12 @@ CodeOceanEditorFlowr = { var stackoverflowRequests = _.map(insights, function (insight) { var queryParams = { accepted: true, - pagesize: 3, + pagesize: <%= CodeOcean::Config.new(:code_ocean).read[:flowr][:answers_per_query] %>, order: 'desc', sort: 'relevance', site: 'stackoverflow', answers: 1, - filter: '!23qca9v**HCO.ESF)dHfT', + filter: '!23qca9v**HCO.ESF)dHfT', // title, body, accepted answer q: insight.query } @@ -87,7 +87,8 @@ CodeOceanEditorFlowr = { this.getInsights().then(function () { var results = self.collectResults(arguments); _.each(results, function (result, index) { - var collapsibleTileHtml = self.flowrResultHtml.replace(/{{collapseId}}/g, 'collapse-' + index).replace(/{{headingId}}/g, 'heading-' + index); + var collapsibleTileHtml = self.flowrResultHtml + .replace(/{{collapseId}}/g, 'collapse-' + index).replace(/{{headingId}}/g, 'heading-' + index); var resultTile = $(collapsibleTileHtml); var questionUrl = 'https://stackoverflow.com/questions/' + result.question_id; diff --git a/config/code_ocean.yml.example b/config/code_ocean.yml.example index b21c190e..f931bc68 100644 --- a/config/code_ocean.yml.example +++ b/config/code_ocean.yml.example @@ -1,12 +1,14 @@ default: &default flowr: enabled: false + answers_per_query: 3 code_pilot: enabled: false development: flowr: enabled: true + answers_per_query: 3 code_pilot: enabled: false url: //localhost:3000