apply changes after review

This commit is contained in:
yqbk
2016-10-11 12:44:16 +02:00
parent 734a0324d4
commit 1945a47109
6 changed files with 14 additions and 45 deletions

View File

@ -21,8 +21,7 @@ describe ExecutionEnvironmentPolicy do
end
end
[:execute_command?, :shell?, :statistics?].each do |action|
[:destroy?, :edit?, :execute_command?, :shell?, :show?, :update?].each do |action|
permissions(action) do
it 'grants access to admins' do
expect(subject).to permit(FactoryGirl.build(:admin), execution_environment)
@ -39,22 +38,4 @@ describe ExecutionEnvironmentPolicy do
end
end
end
[:destroy?, :edit?, :show?, :update?].each do |action|
permissions(action) do
it 'grants access to admins' do
expect(subject).to permit(FactoryGirl.build(:admin), execution_environment)
end
it 'does not grant access to authors' do
expect(subject).not_to permit(execution_environment.author, execution_environment)
end
it 'does not grant access to all other users' do
[:external_user, :teacher].each do |factory_name|
expect(subject).not_to permit(FactoryGirl.build(factory_name), execution_environment)
end
end
end
end
end

View File

@ -15,9 +15,6 @@
#
# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
require "codeclimate-test-reporter"
CodeClimate::TestReporter.start
unless RUBY_PLATFORM == 'java'
if ENV['CODECLIMATE_REPO_TOKEN']
require 'codeclimate-test-reporter'
@ -28,9 +25,6 @@ unless RUBY_PLATFORM == 'java'
end
end
require 'selenium-webdriver'
#Selenium::WebDriver::Firefox::Binary.path='/usr/bin/firefox'
RSpec.configure do |config|
# These two settings work together to allow you to limit a spec run
# to individual examples or groups you care about by tagging them with
@ -39,11 +33,6 @@ RSpec.configure do |config|
config.filter_run :focus
config.run_all_when_everything_filtered = true
#for --next-failure feature purpose
config.example_status_persistence_file_path = "examples.txt"
config.run_all_when_everything_filtered = true
# Many RSpec users commonly either run the entire suite or an individual
# file, and it's useful to allow more verbose output when running an
# individual spec file.