htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prevent parallel execution of run and test during RfC creation

Browse Source 
* Otherwise, the output of both might be mixed and saved incorrectly for the RfC
This commit is contained in:
Sebastian Serth
2021-10-31 12:57:23 +01:00
parent 475aa8c512
commit 1e7cf1c622
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/controllers/request_for_comments_controller.rb
View File

@ -117,12 +117,10 @@ class RequestForCommentsController < ApplicationController
respond_to do |format|
if @request_for_comment.save
# create thread here and execute tests. A run is triggered from the frontend and does not need to be handled here.
Thread.new do
switch_locale { @request_for_comment.submission.calculate_score }
ensure
ActiveRecord::Base.connection_pool.release_connection
end
# execute the tests here and wait until they finished.
# As the same runner is used for the score and test run, no parallelization is possible
# A run is triggered from the frontend and does not need to be handled here.
@request_for_comment.submission.calculate_score
format.json { render :show, status: :created, location: @request_for_comment }
else
format.html { render :new }