From 1f7f2865a0b35fa6cb4ab75caf039ce6562c8865 Mon Sep 17 00:00:00 2001 From: Ralf Teusner Date: Sun, 1 May 2016 12:12:46 +0200 Subject: [PATCH] Some cosmetic changes. Fade out of button after asking a question, some margin to avoid interference of the button with scrollbars, reduced timeframe upon appearance and changed modal window description text. --- app/assets/javascripts/editor.js.erb | 4 +++- app/assets/stylesheets/editor.css.scss | 1 + config/locales/de.yml | 2 +- config/locales/en.yml | 2 +- 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/app/assets/javascripts/editor.js.erb b/app/assets/javascripts/editor.js.erb index b663548f..21afeec7 100644 --- a/app/assets/javascripts/editor.js.erb +++ b/app/assets/javascripts/editor.js.erb @@ -13,7 +13,7 @@ $(function() { var THEME = 'ace/theme/textmate'; var REMEMBER_TAB = false; var AUTOSAVE_INTERVAL = 15 * 1000; - var REQUEST_FOR_COMMENTS_DELAY = 5 * 60 * 1000; + var REQUEST_FOR_COMMENTS_DELAY = 3 * 60 * 1000; var NONE = 0; var WEBSOCKET = 1; var SERVER_SEND_EVENT = 2; @@ -1171,6 +1171,8 @@ $(function() { }).error(ajaxError); $('#comment-modal').modal('hide'); + var button = $('#requestCommentsButton'); + button.fadeOut(); } var initializeCodePilot = function() { diff --git a/app/assets/stylesheets/editor.css.scss b/app/assets/stylesheets/editor.css.scss index 661958b5..ef298c9e 100644 --- a/app/assets/stylesheets/editor.css.scss +++ b/app/assets/stylesheets/editor.css.scss @@ -92,5 +92,6 @@ button i.fa-spin { #requestCommentsButton { position: relative; margin-top: -50px; + margin-right: 25px; float: right; } diff --git a/config/locales/de.yml b/config/locales/de.yml index 7d13a0bc..ddc6bfa4 100644 --- a/config/locales/de.yml +++ b/config/locales/de.yml @@ -248,7 +248,7 @@ de: removeAllOnLine: Meine Kommentare auf dieser Zeile löschen listing: Die neuesten Kommentaranfragen request: "Kommentaranfrage stellen" - question: "Was ist Ihre Frage? (optional)" + question: "Bitte beschreiben Sie kurz ihre Problem oder nennen Sie den Programmteil, zu dem sie Feedback wünschen." index: clone: Duplizieren implement: Implementieren diff --git a/config/locales/en.yml b/config/locales/en.yml index c1d3ac86..f083f5f9 100644 --- a/config/locales/en.yml +++ b/config/locales/en.yml @@ -248,7 +248,7 @@ en: removeAllOnLine: Remove my comments on this line listing: Listing the newest comment requests request: "Request Comments" - question: "What is your question? (optional)" + question: "Please shortly describe your problem or the program part you would like to get feedback for." index: clone: Duplicate implement: Implement