htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rewrite createSubmissionCallback to use real forEach loop

Browse Source
This commit is contained in:
Sebastian Serth
2023-12-22 00:51:54 +01:00
committed by Sebastian Serth
parent e2c8156f0e
commit 21e0784af5
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
app/assets/javascripts/editor/submissions.js
View File

@ -59,7 +59,7 @@ CodeOceanEditorSubmissions = {
}); });
// update the ids of the editors and reload the annotations // update the ids of the editors and reload the annotations
for (var i = 0; i < this.editors.length; i++) { for (const editor of this.editors) {
const file_id_old = $(editor.container).data('file-id'); const file_id_old = $(editor.container).data('file-id');
@ -67,13 +67,12 @@ CodeOceanEditorSubmissions = {
// This is the case, since it is set via a call to ancestor_id on the model, which returns either file_id if set, or id if it is not set. // This is the case, since it is set via a call to ancestor_id on the model, which returns either file_id if set, or id if it is not set.
// therefore the else part is not needed any longer... // therefore the else part is not needed any longer...
// if we have an file_id set (the file is a copy of a teacher supplied given file) and the new file-ids are present in the response // if we have an file_id set (the file is a copy of a teacher supplied given file) and the new file-ids are present in the submission
if (file_id_old != null && data.files){ if (file_id_old != null && submission.files) {
// if we find file_id_old (this is the reference to the base file) in the submission, this is the match // if we find file_id_old (this is the reference to the base file) in the submission, this is the match
for(var j = 0; j< data.files.length; j++){ for (const file of submission.files) {
if(data.files[j].file_id === file_id_old){ if (file.file_id === file_id_old) {
//$(editors[i].container).data('id') = data.files[j].id; $(editor.container).data('id', file.id);
$(this.editors[i].container).data('id', data.files[j].id );
} }
} }
} }