From 264927e3c4a223df23a4d1a4d2232a318558059d Mon Sep 17 00:00:00 2001 From: Sebastian Serth Date: Sat, 15 Jul 2023 18:58:52 +0200 Subject: [PATCH] Fix unnecessary testrun for each successful test / score action. This commit resolves a regression introduced by commit 9c3ec3c7. We still might want to remove this false data from our database, which is still pending. --- app/controllers/submissions_controller.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/controllers/submissions_controller.rb b/app/controllers/submissions_controller.rb index f8e51328..bf6481b5 100644 --- a/app/controllers/submissions_controller.rb +++ b/app/controllers/submissions_controller.rb @@ -263,7 +263,6 @@ class SubmissionsController < ApplicationController kill_client_socket(client_socket) Rails.logger.debug { "Runner error while scoring submission #{@submission.id}: #{e.message}" } @testrun[:passed] = false - ensure save_testrun_output 'assess' end @@ -297,7 +296,6 @@ class SubmissionsController < ApplicationController kill_client_socket(client_socket) Rails.logger.debug { "Runner error while testing submission #{@submission.id}: #{e.message}" } @testrun[:passed] = false - ensure save_testrun_output 'assess' end