From 28a3fa3a868733e411be2da52c41d98f9d204eaf Mon Sep 17 00:00:00 2001 From: Maximilian Grundke Date: Wed, 21 Mar 2018 15:35:59 +0100 Subject: [PATCH] Fix statistics for empty collections and exercises without submissions --- app/models/exercise_collection.rb | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/models/exercise_collection.rb b/app/models/exercise_collection.rb index 661bed81..5c159dda 100644 --- a/app/models/exercise_collection.rb +++ b/app/models/exercise_collection.rb @@ -13,7 +13,12 @@ class ExerciseCollection < ActiveRecord::Base end def average_working_time - exercise_working_times.values.reduce(:+) / exercises.size + if exercises.empty? + 0 + else + values = exercise_working_times.values.reject { |v| v.nil?} + values.reduce(:+) / exercises.size + end end def to_s