Remove legacy save search endpoint
This commit is contained in:
@ -330,8 +330,6 @@ class ExercisesController < ApplicationController
|
|||||||
|
|
||||||
@hide_rfc_button = @embed_options[:disable_rfc]
|
@hide_rfc_button = @embed_options[:disable_rfc]
|
||||||
|
|
||||||
@search = Search.new
|
|
||||||
@search.exercise = @exercise
|
|
||||||
@submission = current_user.submissions.where(exercise_id: @exercise.id).order('created_at DESC').first
|
@submission = current_user.submissions.where(exercise_id: @exercise.id).order('created_at DESC').first
|
||||||
@files = (@submission ? @submission.collect_files : @exercise.files).select(&:visible).sort_by(&:filepath)
|
@files = (@submission ? @submission.collect_files : @exercise.files).select(&:visible).sort_by(&:filepath)
|
||||||
@paths = collect_paths(@files)
|
@paths = collect_paths(@files)
|
||||||
@ -385,18 +383,6 @@ class ExercisesController < ApplicationController
|
|||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
def search
|
|
||||||
search_text = params[:search_text]
|
|
||||||
search = Search.new(user: current_user, exercise: @exercise, search: search_text)
|
|
||||||
|
|
||||||
begin
|
|
||||||
search.save
|
|
||||||
render(json: {success: 'true'})
|
|
||||||
rescue StandardError
|
|
||||||
render(json: {success: 'false', error: "could not save search: #{$ERROR_INFO}"})
|
|
||||||
end
|
|
||||||
end
|
|
||||||
|
|
||||||
def edit; end
|
def edit; end
|
||||||
|
|
||||||
def create
|
def create
|
||||||
@ -414,7 +400,7 @@ class ExercisesController < ApplicationController
|
|||||||
|
|
||||||
def not_authorized_for_exercise(_exception)
|
def not_authorized_for_exercise(_exception)
|
||||||
return render_not_authorized unless current_user
|
return render_not_authorized unless current_user
|
||||||
return render_not_authorized unless %w[implement working_times intervention search reload].include?(action_name)
|
return render_not_authorized unless %w[implement working_times intervention reload].include?(action_name)
|
||||||
|
|
||||||
if current_user.admin? || current_user.teacher?
|
if current_user.admin? || current_user.teacher?
|
||||||
redirect_to(@exercise, alert: t('exercises.implement.unpublished')) if @exercise.unpublished?
|
redirect_to(@exercise, alert: t('exercises.implement.unpublished')) if @exercise.unpublished?
|
||||||
|
@ -1,6 +0,0 @@
|
|||||||
# frozen_string_literal: true
|
|
||||||
|
|
||||||
class Search < ApplicationRecord
|
|
||||||
belongs_to :user, polymorphic: true
|
|
||||||
belongs_to :exercise
|
|
||||||
end
|
|
@ -29,7 +29,7 @@ class ExercisePolicy < AdminOrAuthorPolicy
|
|||||||
define_method(action) { (admin? || teacher_in_study_group? || author?) && @user.codeharbor_link }
|
define_method(action) { (admin? || teacher_in_study_group? || author?) && @user.codeharbor_link }
|
||||||
end
|
end
|
||||||
|
|
||||||
%i[implement? working_times? intervention? search? reload?].each do |action|
|
%i[implement? working_times? intervention? reload?].each do |action|
|
||||||
define_method(action) do
|
define_method(action) do
|
||||||
return no_one unless @record.files.any? {|f| f.hidden == false } && @record.execution_environment.present?
|
return no_one unless @record.files.any? {|f| f.hidden == false } && @record.execution_environment.present?
|
||||||
|
|
||||||
|
@ -6,7 +6,7 @@
|
|||||||
- show_tips_interventions = @show_tips_interventions || "false"
|
- show_tips_interventions = @show_tips_interventions || "false"
|
||||||
- hide_rfc_button = @hide_rfc_button || false
|
- hide_rfc_button = @hide_rfc_button || false
|
||||||
|
|
||||||
#editor.row data-exercise-id=@exercise.id data-message-depleted=t('exercises.editor.depleted') data-message-timeout=t('exercises.editor.timeout', permitted_execution_time: @exercise.execution_environment.permitted_execution_time) data-message-out-of-memory=t('exercises.editor.out_of_memory', memory_limit: @exercise.execution_environment.memory_limit) data-submissions-url=submissions_path data-user-id=current_user.id data-user-external-id=external_user_external_id data-working-times-url=working_times_exercise_path(@exercise) data-intervention-save-url=intervention_exercise_path(@exercise) data-rfc-interventions=show_rfc_interventions data-break-interventions=show_break_interventions data-tips-interventions=show_tips_interventions data-search-save-url=search_exercise_path(@exercise)
|
#editor.row data-exercise-id=@exercise.id data-message-depleted=t('exercises.editor.depleted') data-message-timeout=t('exercises.editor.timeout', permitted_execution_time: @exercise.execution_environment.permitted_execution_time) data-message-out-of-memory=t('exercises.editor.out_of_memory', memory_limit: @exercise.execution_environment.memory_limit) data-submissions-url=submissions_path data-user-id=current_user.id data-user-external-id=external_user_external_id data-working-times-url=working_times_exercise_path(@exercise) data-intervention-save-url=intervention_exercise_path(@exercise) data-rfc-interventions=show_rfc_interventions data-break-interventions=show_break_interventions data-tips-interventions=show_tips_interventions
|
||||||
- unless @embed_options[:hide_sidebar]
|
- unless @embed_options[:hide_sidebar]
|
||||||
- additional_classes = 'sidebar-col'
|
- additional_classes = 'sidebar-col'
|
||||||
- if @tips.blank?
|
- if @tips.blank?
|
||||||
|
@ -617,8 +617,6 @@ de:
|
|||||||
form:
|
form:
|
||||||
study_groups: Lerngruppen
|
study_groups: Lerngruppen
|
||||||
click_to_collapse: Zum Aus-/Einklappen hier klicken...
|
click_to_collapse: Zum Aus-/Einklappen hier klicken...
|
||||||
search:
|
|
||||||
search_in_forum: "Probleme? Suche hier im Forum"
|
|
||||||
locales:
|
locales:
|
||||||
de: Deutsch
|
de: Deutsch
|
||||||
en: Englisch
|
en: Englisch
|
||||||
|
@ -617,8 +617,6 @@ en:
|
|||||||
success: You successfully changed your password.
|
success: You successfully changed your password.
|
||||||
show:
|
show:
|
||||||
link: Profile
|
link: Profile
|
||||||
search:
|
|
||||||
search_in_forum: "Problems? Search here in forum"
|
|
||||||
locales:
|
locales:
|
||||||
de: German
|
de: German
|
||||||
en: English
|
en: English
|
||||||
|
@ -88,7 +88,6 @@ Rails.application.routes.draw do
|
|||||||
get :implement
|
get :implement
|
||||||
get :working_times
|
get :working_times
|
||||||
post :intervention
|
post :intervention
|
||||||
post :search
|
|
||||||
get :statistics
|
get :statistics
|
||||||
get :feedback
|
get :feedback
|
||||||
get :reload
|
get :reload
|
||||||
|
@ -134,7 +134,7 @@ describe ExercisePolicy do
|
|||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
%i[implement? working_times? intervention? search? reload?].each do |action|
|
%i[implement? working_times? intervention? reload?].each do |action|
|
||||||
permissions(action) do
|
permissions(action) do
|
||||||
context 'when the exercise has no visible files' do
|
context 'when the exercise has no visible files' do
|
||||||
let(:exercise) { create(:dummy) }
|
let(:exercise) { create(:dummy) }
|
||||||
|
Reference in New Issue
Block a user