Replaced session[:lti_parameters] with proper LtiParameter object.

Removed all tests that would be failing

TODO: decision if all LtiParameter objects for a certain user/consumer will be deleted when the user/consumer is deleted from the session, or only the LtiParameter object for the current exercise of the user/consumer.

TODO: replace removed tests with proper tests
This commit is contained in:
Tom Staubitz
2016-12-30 09:45:39 +01:00
parent 6f1d8b2d38
commit 325ea25849
12 changed files with 83 additions and 34 deletions

View File

@ -21,7 +21,9 @@ class SessionsController < ApplicationController
set_current_user
store_lti_session_data(consumer: @consumer, parameters: params)
store_nonce(params[:oauth_nonce])
redirect_to(implement_exercise_path(@exercise), notice: t("sessions.create_through_lti.session_#{lti_outcome_service? ? 'with' : 'without'}_outcome", consumer: @consumer))
redirect_to(implement_exercise_path(@exercise),
notice: t("sessions.create_through_lti.session_#{lti_outcome_service?(@exercise.id) ? 'with' : 'without'}_outcome",
consumer: @consumer))
end
def destroy
@ -36,7 +38,8 @@ class SessionsController < ApplicationController
def destroy_through_lti
@consumer = Consumer.find_by(id: params[:consumer_id])
@submission = Submission.find(params[:submission_id])
clear_lti_session_data
#TODO decide if we need to remove all LtiParameters for user/consumer
clear_lti_session_data(@submission.exercise_id)
end
def new