htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replaced session[:lti_parameters] with proper LtiParameter object.

Browse Source 
Removed all tests that would be failing

TODO: decision if all LtiParameter objects for a certain user/consumer will be deleted when the user/consumer is deleted from the session, or only the LtiParameter object for the current exercise of the user/consumer.

TODO: replace removed tests with proper tests
This commit is contained in:
Tom Staubitz
2016-12-30 09:45:39 +01:00
parent 6f1d8b2d38
commit 325ea25849
12 changed files with 83 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/views/exercises/_editor_output.html.slim
View File

@@ -27,8 +27,9 @@ div id='output_sidebar_uncollapsed' class='hidden col-sm-12 enforce-bottom-margi
.progress-bar role='progressbar'
br
/ #Todo replace session with lti_parameter
- if session[:lti_parameters].try(:has_key?, 'lis_outcome_service_url')
/ #Todo replace session with lti_parameter /done
/- if session[:lti_parameters].try(:has_key?, 'lis_outcome_service_url')
- if lti_outcome_service?(@exercise.id)
p.text-center = render('editor_button', classes: 'btn-lg btn-success', data: {:'data-url' => submit_exercise_path(@exercise)}, icon: 'fa fa-send', id: 'submit', label: t('exercises.editor.submit'))
- else
p.text-center = render('editor_button', classes: 'btn-lg btn-warning-outline', data: {:'data-placement' => 'bottom', :'data-tooltip' => true}, icon: 'fa fa-clock-o', id: 'submit_outdated', label: t('exercises.editor.exercise_deadline_passed'), title: t('exercises.editor.tooltips.exercise_deadline_passed'))