Rename attribute and restructure conditions

app/controllers/concerns/submission_scoring.rb

@@ -9,7 +9,7 @@ module SubmissionScoring
         assessment = assessor.assess(output)
         passed = ((assessment[:passed] == assessment[:count]) and (assessment[:score] > 0))
         testrun_output = passed ? nil : 'message: ' + output[:message].to_s + "\n stdout: " + output[:stdout].to_s + "\n stderr: " + output[:stderr].to_s
-        if !testrun_output.blank?
+        unless testrun_output.blank?
           submission.exercise.execution_environment.error_templates.each do |template|
             pattern = Regexp.new(template.signature).freeze
             if pattern.match(testrun_output)

app/controllers/submissions_controller.rb

@@ -203,11 +203,11 @@ class SubmissionsController < ApplicationController
   end
 
   def extract_errors
-    if !@message_buffer.blank?
+    unless @run_output.blank?
       @submission.exercise.execution_environment.error_templates.each do |template|
         pattern = Regexp.new(template.signature).freeze
-        if pattern.match(@message_buffer)
-          StructuredError.create_from_template(template, @message_buffer)
+        if pattern.match(@run_output)
+          StructuredError.create_from_template(template, @run_output)
         end
       end
     end