htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clarify strategy creation in runner.rb with comment

Browse Source
This commit is contained in:
Sebastian Serth
2021-10-17 16:43:39 +02:00
parent 7285978ea3
commit 352e5f4329
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/runner.rb
View File

@ -25,8 +25,10 @@ class Runner < ApplicationRecord
runner = find_by(user: user, execution_environment: execution_environment) runner = find_by(user: user, execution_environment: execution_environment)
if runner.nil? if runner.nil?
runner = Runner.create(user: user, execution_environment: execution_environment) runner = Runner.create(user: user, execution_environment: execution_environment)
# The `strategy` is added through the before_validation hook `:request_id`.
raise Runner::Error::Unknown.new("Runner could not be saved: #{runner.errors.inspect}") unless runner.persisted? raise Runner::Error::Unknown.new("Runner could not be saved: #{runner.errors.inspect}") unless runner.persisted?
else else
# This information is required but not persisted in the runner model.
runner.strategy = strategy_class.new(runner.runner_id, runner.execution_environment) runner.strategy = strategy_class.new(runner.runner_id, runner.execution_environment)
end end