htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Pass exercise object instead of id to reject_illegal_file_attributes

Browse Source
This commit is contained in:
tobias.kantusch
2021-04-26 15:27:32 +02:00
committed by Sebastian Serth
parent b3c110cead
commit 36cacc2330
4 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/controllers/concerns/file_parameters.rb
View File

@ -1,12 +1,12 @@
# frozen_string_literal: true
module FileParameters
def reject_illegal_file_attributes(exercise_id, params)
if Exercise.exists?(id: exercise_id) && params
def reject_illegal_file_attributes(exercise, params)
if exercise && params
params.reject do |_, file_attributes|
file = CodeOcean::File.find_by(id: file_attributes[:file_id])
# avoid that public files from other contexts can be created
file.nil? || file.hidden || file.read_only || file.context_id != exercise_id.to_i
file.nil? || file.hidden || file.read_only || file.context_id != exercise.id
end
else
[]