From 3faaf3db514c77e8c22897bf4425e4ebbb4d4299 Mon Sep 17 00:00:00 2001
From: Felix Auringer <48409110+felixauringer@users.noreply.github.com>
Date: Wed, 19 May 2021 11:01:41 +0200
Subject: [PATCH] Add dependency for charlock_holmes to docs and provision
 scripts

---
 docs/LOCAL_SETUP.md                | 6 +++++-
 provision/provision.docker.root.sh | 2 +-
 provision/provision.vagrant.sh     | 2 +-
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/docs/LOCAL_SETUP.md b/docs/LOCAL_SETUP.md
index fe0ba695..6542d610 100644
--- a/docs/LOCAL_SETUP.md
+++ b/docs/LOCAL_SETUP.md
@@ -86,7 +86,7 @@ This will launch a dedicated server on port 3035 (default setting) and allow inc
 Install all necessary dependencies:
 
 ```bash
-sudo apt install apt-transport-https ca-certificates curl gnupg-agent software-properties-common firefox firefox-geckodriver libpq-dev
+sudo apt install apt-transport-https ca-certificates curl gnupg-agent software-properties-common firefox firefox-geckodriver libpq-dev libicu-dev
 ```
 
 ### PostgreSQL
@@ -252,6 +252,10 @@ source "$HOME/.profile"
   brew install docker
   open /Applications/Docker.app/
   ```
+- Install icu4c for detecting character encodings
+  ```shell script
+  brew install icu4c
+  ```
 - Install nginx and adopt its config to forward requests to the **RAW** docker UNIX socket (see [this issue](https://github.com/docker/for-mac/issues/1662) for more details). Only required for macOS!
   ```shell script
   brew install nginx
diff --git a/provision/provision.docker.root.sh b/provision/provision.docker.root.sh
index 31851709..cd4937a6 100644
--- a/provision/provision.docker.root.sh
+++ b/provision/provision.docker.root.sh
@@ -11,7 +11,7 @@ geckodriver_version=0.26.0
 # Prerequisites
 apt -qq update
 DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends tzdata
-apt -qq -y install apt-transport-https ca-certificates curl gnupg-agent software-properties-common firefox firefox-geckodriver libpq-dev wget lsb-release sudo zlib1g-dev git build-essential
+apt -qq -y install apt-transport-https ca-certificates curl gnupg-agent software-properties-common firefox firefox-geckodriver libpq-dev libicu-dev wget lsb-release sudo zlib1g-dev git build-essential
 
 DISTRO="$(lsb_release -cs)"
 USER="codeocean"
diff --git a/provision/provision.vagrant.sh b/provision/provision.vagrant.sh
index 328f898c..24060d50 100644
--- a/provision/provision.vagrant.sh
+++ b/provision/provision.vagrant.sh
@@ -12,7 +12,7 @@ DISTRO="$(lsb_release -cs)"
 
 # Prerequisites
 sudo apt -qq update
-sudo apt -qq -y install apt-transport-https ca-certificates curl gnupg-agent software-properties-common firefox firefox-geckodriver libpq-dev
+sudo apt -qq -y install apt-transport-https ca-certificates curl gnupg-agent software-properties-common firefox firefox-geckodriver libpq-dev libicu-dev
 sudo apt -qq -y upgrade
 
 # PostgreSQL