Directly use ActiveRecord object instead of ID

This change will improve the performance by reducing unnecessary SELECT queries.
This commit is contained in:
Sebastian Serth
2023-02-18 19:28:26 +01:00
parent 6465404ebe
commit 40c7a50834
3 changed files with 5 additions and 6 deletions

View File

@ -3,8 +3,8 @@
module CodeOcean
class FileNameValidator < ActiveModel::Validator
def validate(record)
existing_files = File.where(name: record.name, path: record.path, file_type_id: record.file_type_id,
context_id: record.context_id, context_type: record.context_type).to_a
existing_files = File.where(name: record.name, path: record.path, file_type: record.file_type,
context: record.context)
if !existing_files.empty? && (!record.context.is_a?(Exercise) || record.context.new_record?)
record.errors.add(:base, 'Duplicate')
end