specs for services

app/services/exercise_service/check_external.rb

@@ -16,8 +16,8 @@ module ExerciseService
       response_hash = JSON.parse(response.body, symbolize_names: true)
 
       {error: false}.merge(response_hash.slice(:message, :exercise_found, :update_right))
-    rescue Faraday::Error => e
-      {error: true, message: I18n.t('exercises.export_codeharbor.error', message: e.message)}
+    rescue Faraday::Error, JSON::ParserError
+      {error: true, message: I18n.t('exercises.export_codeharbor.error')}
     end
 
     private

app/services/exercise_service/push_external.rb

@@ -17,9 +17,9 @@ module ExerciseService
           request.body = body
         end
 
-        return response.success? ? nil : response.body
+        response.success? ? nil : response.body
       rescue StandardError => e
-        return e.message
+        e.message
       end
     end