htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Further check for programming group and add custom logging

Browse Source 
Fixes CODEOCEAN-V2
This commit is contained in:
Sebastian Serth
2023-09-22 16:48:43 +02:00
parent 40aa50f772
commit 47dd4cf4f7
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/channels/synchronized_editor_channel.rb
View File

@ -31,6 +31,8 @@ class SynchronizedEditorChannel < ApplicationCable::Channel
def specific_channel def specific_channel
reject unless ProgrammingGroupPolicy.new(current_user, programming_group).stream_sync_editor? reject unless ProgrammingGroupPolicy.new(current_user, programming_group).stream_sync_editor?
"synchronized_editor_channel_group_#{programming_group.id}" "synchronized_editor_channel_group_#{programming_group.id}"
rescue NoMethodError => e
Sentry.capture_exception(e, extras: {current_user:, programming_group:, session_id: @session_id, identifier: @identifier})
end end
def programming_group def programming_group

2
app/policies/programming_group_policy.rb
View File

@ -11,7 +11,7 @@ class ProgrammingGroupPolicy < ApplicationPolicy
def stream_sync_editor? def stream_sync_editor?
# A programming group needs to exist for the user to be able to stream the synchronized editor. # A programming group needs to exist for the user to be able to stream the synchronized editor.
return false unless @record return false if @record.blank?
admin? || author_in_programming_group? admin? || author_in_programming_group?
end end