htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix test for new custom file

Browse Source
This commit is contained in:
Sebastian Serth
2021-05-14 17:35:37 +02:00
parent bf6ab4f114
commit 48904a19fd
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/concerns/file_parameters.rb
View File

@ -6,7 +6,7 @@ module FileParameters
params.reject do |_, file_attributes| params.reject do |_, file_attributes|
file = CodeOcean::File.find_by(id: file_attributes[:file_id]) file = CodeOcean::File.find_by(id: file_attributes[:file_id])
# avoid that public files from other contexts can be created # avoid that public files from other contexts can be created
file.nil? || file.hidden || file.read_only || file.context == 'Exercise' && file.context_id != exercise.id file.nil? || file.hidden || file.read_only || file.context_type == 'Exercise' && file.context_id != exercise.id
end end
else else
[] []

3
spec/concerns/file_parameters_spec.rb
View File

@ -24,7 +24,8 @@ describe FileParameters do
end end
it 'new file' do it 'new file' do
new_file = FactoryBot.create(:file, context: hello_world) submission = FactoryBot.create(:submission, exercise: hello_world, id: 1337)
new_file = FactoryBot.create(:file, context: submission)
expect(file_accepted?(new_file)).to be true expect(file_accepted?(new_file)).to be true
end end
end end