change error policies

spec/policies/error_policy_spec.rb

@@ -5,32 +5,36 @@ describe ErrorPolicy do
 
   let(:error) { FactoryGirl.build(:error) }
 
-  permissions :index? do
+  [:create?, :index?, :new?].each do |action|
-    it 'grants access to admins' do
+    permissions(action) do
-      expect(subject).to permit(FactoryGirl.build(:admin), error)
+      it 'grants access to admins' do
-    end
+        expect(subject).to permit(FactoryGirl.build(:admin), error)
+      end
 
-    it 'grants access to teachers' do
+      it 'grants access to teachers' do
-      expect(subject).to permit(FactoryGirl.build(:teacher), error)
+        expect(subject).to permit(FactoryGirl.build(:teacher), error)
-    end
+      end
 
-    it 'does not grant access to external users' do
+      it 'does not grant access to external users' do
-      expect(subject).not_to permit(FactoryGirl.build(:external_user), error)
+        expect(subject).not_to permit(FactoryGirl.build(:external_user), error)
+      end
     end
   end
 
-  permissions :show? do
+  [:destroy?, :edit?, :show?, :update?].each do |action|
-    it 'grants access to admins' do
+    permissions(action) do
-      expect(subject).to permit(FactoryGirl.build(:admin), error)
+      it 'grants access to admins' do
-    end
+        expect(subject).to permit(FactoryGirl.build(:admin), error)
+      end
 
-    it 'grants access to authors' do
+      it 'grants access to authors' do
-      expect(subject).to permit(error.execution_environment.author, error)
+        expect(subject).to permit(error.execution_environment.author, error)
-    end
+      end
 
-    it 'does not grant access to all other users' do
+      it 'does not grant access to all other users' do
-      [:external_user, :teacher].each do |factory_name|
+        [:external_user, :teacher].each do |factory_name|
-        expect(subject).not_to permit(FactoryGirl.build(factory_name), error)
+          expect(subject).not_to permit(FactoryGirl.build(factory_name), error)
+        end
       end
     end
   end