From 4e61d53cb3e24023d91cafa46d9f5d1299db81e5 Mon Sep 17 00:00:00 2001 From: Karol Date: Sun, 1 Nov 2020 11:18:06 +0100 Subject: [PATCH] typos and cleanup --- app/controllers/exercises_controller.rb | 4 ++-- config/locales/en.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/controllers/exercises_controller.rb b/app/controllers/exercises_controller.rb index 9eca85cf..b8bc9f32 100644 --- a/app/controllers/exercises_controller.rb +++ b/app/controllers/exercises_controller.rb @@ -178,7 +178,6 @@ class ExercisesController < ApplicationController user = user_from_api_key return render json: {}, status: 401 if user.nil? - exercise = nil ActiveRecord::Base.transaction do exercise = ::ProformaService::Import.call(zip: tempfile, user: user) exercise.save! @@ -188,7 +187,8 @@ class ExercisesController < ApplicationController render json: {}, status: 401 rescue Proforma::ProformaError render json: t('exercises.import_codeharbor.import_errors.invalid'), status: 400 - rescue StandardError + rescue StandardError => e + Raven.capture_exception(e) render json: t('exercises.import_codeharbor.import_errors.internal_error'), status: 500 end diff --git a/config/locales/en.yml b/config/locales/en.yml index 88bfb196..2b4b033f 100644 --- a/config/locales/en.yml +++ b/config/locales/en.yml @@ -344,7 +344,7 @@ en: import_codeharbor: import_errors: invalid: Invalid exercise - internal_error: An internal error occurred on Codeharbor while importing the exercise. + internal_error: An internal error occurred on Codeocean while importing the exercise. export_codeharbor: label: Export to Codeharbor dialogtitle: Export to Codeharbor