From 4fa4629e1525d2247003333706003ced19884384 Mon Sep 17 00:00:00 2001
From: Hauke Klement <dev@hklement.de>
Date: Thu, 12 Feb 2015 15:10:53 +0100
Subject: [PATCH] reduced code complexity

---
 app/models/submission.rb | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/app/models/submission.rb b/app/models/submission.rb
index 91d75402..b783ec1b 100644
--- a/app/models/submission.rb
+++ b/app/models/submission.rb
@@ -13,10 +13,15 @@ class Submission < ActiveRecord::Base
   validates :cause, inclusion: {in: CAUSES}
   validates :exercise_id, presence: true
 
+  def build_files_hash(files, attribute)
+    files.map(&attribute.to_proc).zip(files).to_h
+  end
+  private :build_files_hash
+
   def collect_files
-    ancestors = exercise.files.map(&:id).zip(exercise.files)
-    descendants = files.map(&:file_id).zip(files)
-    (ancestors + descendants).to_h.values
+    ancestors = build_files_hash(exercise.files, :id)
+    descendants = build_files_hash(files, :file_id)
+    ancestors.merge(descendants).values
   end
 
   def execution_environment