From 06ce498d0210e3725b9f76a6bf14bdb13af5e710 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 1 Mar 2022 03:02:15 +0000 Subject: [PATCH 1/2] Bump rubocop-rspec from 2.8.0 to 2.9.0 Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) from 2.8.0 to 2.9.0. - [Release notes](https://github.com/rubocop/rubocop-rspec/releases) - [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop-rspec/compare/v2.8.0...v2.9.0) --- updated-dependencies: - dependency-name: rubocop-rspec dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index f2d39903..2af196f6 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -427,7 +427,7 @@ GEM activesupport (>= 4.2.0) rack (>= 1.1) rubocop (>= 1.7.0, < 2.0) - rubocop-rspec (2.8.0) + rubocop-rspec (2.9.0) rubocop (~> 1.19) ruby-progressbar (1.11.0) ruby-vips (2.1.4) From b2656bd6b50c60416786d77eb0d738d5d255b967 Mon Sep 17 00:00:00 2001 From: Sebastian Serth Date: Tue, 1 Mar 2022 15:35:08 +0100 Subject: [PATCH 2/2] Fix rubocop offenses --- spec/lib/port_pool_spec.rb | 2 +- spec/services/exercise_service/push_external_spec.rb | 4 ++-- spec/services/proforma_service/export_task_spec.rb | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/spec/lib/port_pool_spec.rb b/spec/lib/port_pool_spec.rb index 3294c106..6f38b8ab 100644 --- a/spec/lib/port_pool_spec.rb +++ b/spec/lib/port_pool_spec.rb @@ -24,7 +24,7 @@ describe PortPool do it 'returns the port' do available_ports = described_class.instance_variable_get(:@available_ports) described_class.instance_variable_set(:@available_ports, []) - expect(described_class.available_port).to be nil + expect(described_class.available_port).to be_nil described_class.instance_variable_set(:@available_ports, available_ports) end end diff --git a/spec/services/exercise_service/push_external_spec.rb b/spec/services/exercise_service/push_external_spec.rb index 2a52075f..28e145e2 100644 --- a/spec/services/exercise_service/push_external_spec.rb +++ b/spec/services/exercise_service/push_external_spec.rb @@ -45,7 +45,7 @@ RSpec.describe ExerciseService::PushExternal do end context 'when response status is success' do - it { is_expected.to be nil } + it { is_expected.to be_nil } context 'when response status is 500' do let(:status) { 500 } @@ -58,7 +58,7 @@ RSpec.describe ExerciseService::PushExternal do context 'when an error occurs' do before { allow(Faraday).to receive(:new).and_raise(StandardError) } - it { is_expected.not_to be nil } + it { is_expected.not_to be_nil } end end end diff --git a/spec/services/proforma_service/export_task_spec.rb b/spec/services/proforma_service/export_task_spec.rb index 78e91f36..3937f08a 100644 --- a/spec/services/proforma_service/export_task_spec.rb +++ b/spec/services/proforma_service/export_task_spec.rb @@ -16,7 +16,7 @@ describe ProformaService::ExportTask do subject(:export_task) { described_class.new } it 'assigns exercise' do - expect(export_task.instance_variable_get(:@exercise)).to be nil + expect(export_task.instance_variable_get(:@exercise)).to be_nil end end end