htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix rubocop offenses - Requires Ruby 3.1+

Browse Source
This commit is contained in:
Sebastian Serth
2022-11-25 10:53:14 +01:00
parent bdf474e684
commit 574e99eddd
93 changed files with 315 additions and 315 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
spec/features/authentication_spec.rb
View File

@ -34,7 +34,7 @@ describe 'Authentication' do
end
context 'with no authentication token' do
let(:request_for_comment) { create(:rfc_with_comment, user: user) }
let(:request_for_comment) { create(:rfc_with_comment, user:) }
let(:rfc_path) { request_for_comment_url(request_for_comment) }
it 'denies access to the request for comment' do
@ -49,7 +49,7 @@ describe 'Authentication' do
context 'with an authentication token' do
let(:user) { create(:learner) }
let(:study_group) { request_for_comment.submission.study_group }
let(:request_for_comment) { create(:rfc_with_comment, user: user) }
let(:request_for_comment) { create(:rfc_with_comment, user:) }
let(:commenting_user) { InternalUser.create(attributes_for(:teacher)) }
let(:mail) { UserMailer.got_new_comment(request_for_comment.comments.first, request_for_comment, commenting_user) }
let(:rfc_link) { request_for_comment_url(request_for_comment, token: token.shared_secret) }
@ -57,7 +57,7 @@ describe 'Authentication' do
before { allow(AuthenticationToken).to receive(:generate!).with(user, study_group).and_return(token).once }
context 'when the token is valid' do
let(:token) { create(:authentication_token, user: user, study_group: study_group) }
let(:token) { create(:authentication_token, user:, study_group:) }
it 'allows access to the request for comment' do
mail.deliver_now
@ -68,7 +68,7 @@ describe 'Authentication' do
end
context 'with an expired authentication token' do
let(:token) { create(:authentication_token, :invalid, user: user, study_group: study_group) }
let(:token) { create(:authentication_token, :invalid, user:, study_group:) }
it 'denies access to the request for comment' do
mail.deliver_now
@ -81,7 +81,7 @@ describe 'Authentication' do
end
context 'when the authentication token is used to login' do
let(:token) { create(:authentication_token, user: user, study_group: study_group) }
let(:token) { create(:authentication_token, user:, study_group:) }
it 'invalidates the token on login' do
mail.deliver_now
@ -108,14 +108,14 @@ describe 'Authentication' do
end
context 'with an authentication token' do
let(:request_for_comment) { create(:rfc_with_comment, user: user) }
let(:request_for_comment) { create(:rfc_with_comment, user:) }
let(:study_group) { request_for_comment.submission.study_group }
let(:commenting_user) { InternalUser.create(attributes_for(:teacher)) }
let(:mail) { UserMailer.got_new_comment(request_for_comment.comments.first, request_for_comment, commenting_user) }
let(:rfc_link) { request_for_comment_url(request_for_comment, token: token.shared_secret) }
it 'still invalidates the token on login' do
token = create(:authentication_token, user: user, study_group: study_group)
token = create(:authentication_token, user:, study_group:)
mail = UserMailer.got_new_comment(request_for_comment.comments.first, request_for_comment, commenting_user)
mail.deliver_now
visit(request_for_comment_url(request_for_comment, token: token.shared_secret))

2
spec/features/editor_spec.rb
View File

@ -111,7 +111,7 @@ describe 'Editor', js: true do
end
it 'contains a button for submitting the exercise' do
submission = build(:submission, user: user, exercise: exercise)
submission = build(:submission, user:, exercise:)
allow(submission).to receive(:calculate_score).and_return(scoring_response)
allow(Submission).to receive(:find).and_return(submission)
click_button(I18n.t('exercises.editor.score'))

14
spec/features/external_user_statistics_spec.rb
View File

@ -4,15 +4,15 @@ require 'rails_helper'
describe 'ExternalUserStatistics', js: true do
let(:learner) { create(:external_user) }
let(:exercise) { create(:dummy, user: user) }
let(:exercise) { create(:dummy, user:) }
let(:study_group) { create(:study_group) }
let(:password) { 'password123456' }
before do
2.times { create(:submission, cause: 'autosave', user: learner, exercise: exercise, study_group: study_group) }
2.times { create(:submission, cause: 'run', user: learner, exercise: exercise, study_group: study_group) }
create(:submission, cause: 'assess', user: learner, exercise: exercise, study_group: study_group)
create(:submission, cause: 'submit', user: learner, exercise: exercise, study_group: study_group)
2.times { create(:submission, cause: 'autosave', user: learner, exercise:, study_group:) }
2.times { create(:submission, cause: 'run', user: learner, exercise:, study_group:) }
create(:submission, cause: 'assess', user: learner, exercise:, study_group:)
create(:submission, cause: 'submit', user: learner, exercise:, study_group:)
study_group.external_users << learner
study_group.internal_users << user
@ -27,7 +27,7 @@ describe 'ExternalUserStatistics', js: true do
end
context 'when a admin accesses the page' do
let(:user) { create(:admin, password: password) }
let(:user) { create(:admin, password:) }
it 'does display the option to enable autosaves' do
expect(page).to have_content(I18n.t('exercises.external_users.statistics.toggle_status_on')).or have_content(I18n.t('exercises.external_users.statistics.toggle_status_off'))
@ -35,7 +35,7 @@ describe 'ExternalUserStatistics', js: true do
end
context 'when a teacher accesses the page' do
let(:user) { create(:teacher, password: password) }
let(:user) { create(:teacher, password:) }
it 'does not display the option to enable autosaves' do
expect(page).not_to have_content(I18n.t('exercises.external_users.statistics.toggle_status_on'))