Fix rubocop offenses - Requires Ruby 3.1+

This commit is contained in:
Sebastian Serth
2022-11-25 10:53:14 +01:00
parent bdf474e684
commit 574e99eddd
93 changed files with 315 additions and 315 deletions

View File

@ -6,7 +6,7 @@ describe Assessor do
let(:assessor) { described_class.new(execution_environment: build(:ruby)) }
describe '#assess' do
let(:assess) { assessor.assess(stdout: stdout) }
let(:assess) { assessor.assess(stdout:) }
let(:stdout) { "Finished in 0.1 seconds (files took 0.1 seconds to load)\n2 examples, 1 failure" }
context 'when an error occurs' do
@ -39,7 +39,7 @@ describe Assessor do
describe '#calculate_score' do
let(:count) { 42 }
let(:passed) { 17 }
let(:test_outcome) { {count: count, passed: passed} }
let(:test_outcome) { {count:, passed:} }
it 'returns the correct score' do
expect(assessor.send(:calculate_score, test_outcome)).to eq(passed.to_f / count)

View File

@ -13,7 +13,7 @@ describe JunitAdapter do
let(:error_matches) { [] }
it 'returns the correct numbers' do
expect(adapter.parse_output(stdout: stdout)).to eq(count: count, failed: failed, error_messages: error_matches)
expect(adapter.parse_output(stdout:)).to eq(count:, failed:, error_messages: error_matches)
end
end
@ -22,7 +22,7 @@ describe JunitAdapter do
let(:stdout) { "OK (#{count} tests)" }
it 'returns the correct numbers' do
expect(adapter.parse_output(stdout: stdout)).to eq(count: count, passed: count)
expect(adapter.parse_output(stdout:)).to eq(count:, passed: count)
end
end
end

View File

@ -10,7 +10,7 @@ describe MochaAdapter do
describe '#parse_output' do
it 'returns the correct numbers' do
expect(adapter.parse_output(stdout: stdout)).to eq(count: count, failed: failed)
expect(adapter.parse_output(stdout:)).to eq(count:, failed:)
end
end
end

View File

@ -11,7 +11,7 @@ describe PyUnitAdapter do
describe '#parse_output' do
it 'returns the correct numbers' do
expect(adapter.parse_output(stderr: stderr)).to eq(count: count, failed: failed, error_messages: error_matches)
expect(adapter.parse_output(stderr:)).to eq(count:, failed:, error_messages: error_matches)
end
end
end

View File

@ -10,7 +10,7 @@ describe RspecAdapter do
describe '#parse_output' do
it 'returns the correct numbers' do
expect(adapter.parse_output(stdout: stdout)).to eq(count: count, failed: failed)
expect(adapter.parse_output(stdout:)).to eq(count:, failed:)
end
end
end

View File

@ -145,7 +145,7 @@ describe Runner::Strategy::Poseidon do
it "returns true on status #{status}" do
faraday_connection = instance_double Faraday::Connection
allow(described_class).to receive(:http_connection).and_return(faraday_connection)
allow(faraday_connection).to receive(:put).and_return(Faraday::Response.new(status: status))
allow(faraday_connection).to receive(:put).and_return(Faraday::Response.new(status:))
expect(action.call).to be_truthy
end
end
@ -154,7 +154,7 @@ describe Runner::Strategy::Poseidon do
it "raises an exception on status #{status}" do
faraday_connection = instance_double Faraday::Connection
allow(described_class).to receive(:http_connection).and_return(faraday_connection)
allow(faraday_connection).to receive(:put).and_return(Faraday::Response.new(status: status))
allow(faraday_connection).to receive(:put).and_return(Faraday::Response.new(status:))
expect { action.call }.to raise_exception Runner::Error::UnexpectedResponse
end
end
@ -248,7 +248,7 @@ describe Runner::Strategy::Poseidon do
.stub_request(:post, "#{described_class.config[:url]}/runners/#{runner_id}/execute")
.with(
body: {
command: command,
command:,
timeLimit: execution_environment.permitted_execution_time,
privilegedExecution: execution_environment.privileged_execution,
},

View File

@ -10,7 +10,7 @@ describe SqlResultSetComparatorAdapter do
let(:stdout) { "Missing tuples: [1]\nUnexpected tuples: []" }
it 'considers the test as failed' do
expect(adapter.parse_output(stdout: stdout)).to eq(count: 1, failed: 1)
expect(adapter.parse_output(stdout:)).to eq(count: 1, failed: 1)
end
end
@ -18,7 +18,7 @@ describe SqlResultSetComparatorAdapter do
let(:stdout) { "Missing tuples: []\nUnexpected tuples: [1]" }
it 'considers the test as failed' do
expect(adapter.parse_output(stdout: stdout)).to eq(count: 1, failed: 1)
expect(adapter.parse_output(stdout:)).to eq(count: 1, failed: 1)
end
end
@ -26,7 +26,7 @@ describe SqlResultSetComparatorAdapter do
let(:stdout) { "Missing tuples: []\nUnexpected tuples: []" }
it 'considers the test as passed' do
expect(adapter.parse_output(stdout: stdout)).to eq(count: 1, passed: 1)
expect(adapter.parse_output(stdout:)).to eq(count: 1, passed: 1)
end
end
end

View File

@ -11,19 +11,19 @@ describe TestingFrameworkAdapter do
describe '#augment_output' do
context 'when missing the count of all tests' do
it 'adds the count of all tests' do
expect(adapter.send(:augment_output, failed: failed, passed: passed)).to include(count: count)
expect(adapter.send(:augment_output, failed:, passed:)).to include(count:)
end
end
context 'when missing the count of failed tests' do
it 'adds the count of failed tests' do
expect(adapter.send(:augment_output, count: count, passed: passed)).to include(failed: failed)
expect(adapter.send(:augment_output, count:, passed:)).to include(failed:)
end
end
context 'when missing the count of passed tests' do
it 'adds the count of passed tests' do
expect(adapter.send(:augment_output, count: count, failed: failed)).to include(passed: passed)
expect(adapter.send(:augment_output, count:, failed:)).to include(passed:)
end
end
end
@ -42,7 +42,7 @@ describe TestingFrameworkAdapter do
describe '#test_outcome' do
it 'calls the framework-specific implementation' do
allow(adapter).to receive(:parse_output).and_return(count: count, failed: failed, passed: passed)
allow(adapter).to receive(:parse_output).and_return(count:, failed:, passed:)
expect(adapter).to receive(:parse_output)
adapter.test_outcome('')
end