From 591d520e26d5b891a4b2aa3efcac6c64e2ed3447 Mon Sep 17 00:00:00 2001 From: Sebastian Serth Date: Sun, 24 Apr 2022 19:00:02 +0200 Subject: [PATCH] Connection::Buffer: Improve performance for deleting \r suffix --- lib/runner/connection/buffer.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/runner/connection/buffer.rb b/lib/runner/connection/buffer.rb index 022b9299..79ff4e6c 100644 --- a/lib/runner/connection/buffer.rb +++ b/lib/runner/connection/buffer.rb @@ -72,7 +72,8 @@ class Runner::Connection::Buffer @global_buffer = +'' # For our buffering, we identified line breaks with the `\n` and removed those temporarily. # Thus, we now re-add the `\n` at the end of the string and (optionally) remove a trailing `\r` at the same time. - message = "#{message.delete_suffix("\r")}\n" + message.delete_suffix!("\r") + message += "\n" @line_buffer.push message end