From 591f776f697be619ab495000f21329bbd1f178b2 Mon Sep 17 00:00:00 2001 From: Sebastian Serth Date: Wed, 16 Nov 2022 23:16:49 +0100 Subject: [PATCH] Close WebSocket connection normally With Tubesock, we need to send a close frame ourselves. Otherwise, some browsers might display a warning. --- app/controllers/submissions_controller.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/app/controllers/submissions_controller.rb b/app/controllers/submissions_controller.rb index 30d492e6..b0e69e59 100644 --- a/app/controllers/submissions_controller.rb +++ b/app/controllers/submissions_controller.rb @@ -298,6 +298,7 @@ class SubmissionsController < ApplicationController def kill_client_socket(client_socket) # We don't want to store this (arbitrary) exit command and redirect it ourselves client_socket.send_data JSON.dump({cmd: :exit}) + client_socket.send_data nil, :close client_socket.close end