htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reuse jQuery selector where possible

Browse Source
This commit is contained in:
Sebastian Serth
2023-12-22 00:45:44 +01:00
committed by Sebastian Serth
parent affeb2d3ba
commit 5b35ccdfe8
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/assets/javascripts/editor/participantsupport.js.erb
View File

@ -108,13 +108,15 @@ CodeOceanEditorFlowr = {
CodeOceanEditorRequestForComments = { CodeOceanEditorRequestForComments = {
requestComments: function () { requestComments: function () {
const cause = $('#requestComments'); const cause = $('#requestComments');
const editor = $('#editor')
const questionElement = $('#question')
this.startSentryTransaction(cause); this.startSentryTransaction(cause);
$('#question').prop("disabled", true); questionElement.prop("disabled", true);
$('#closeAskForCommentsButton').addClass('d-none'); $('#closeAskForCommentsButton').addClass('d-none');
var exercise_id = $('#editor').data('exercise-id'); var exercise_id = editor.data('exercise-id');
var file_id = $('.editor').data('id'); var file_id = $('.editor').data('id');
var question = $('#question').val(); var question = questionElement.val();
var createRequestForComments = function (submission) { var createRequestForComments = function (submission) {
this.showSpinner($('#askForCommentsButton')); this.showSpinner($('#askForCommentsButton'));

2
app/assets/javascripts/editor/submissions.js
View File

@ -163,7 +163,7 @@ CodeOceanEditorSubmissions = {
this.startSentryTransaction(cause); this.startSentryTransaction(cause);
event.preventDefault(); event.preventDefault();
this.stopCode(event); this.stopCode(event);
if ($('#run').is(':visible')) { if (cause.is(':visible')) {
this.createSubmission(cause, null, this.runSubmission.bind(this)); this.createSubmission(cause, null, this.runSubmission.bind(this));
} }
}, },