From 64365025dc47c84fe589c94d0b1b3de142935855 Mon Sep 17 00:00:00 2001 From: Hauke Klement Date: Sat, 7 Mar 2015 16:13:20 +0100 Subject: [PATCH] minor improvements --- app/assets/javascripts/editor.js | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/app/assets/javascripts/editor.js b/app/assets/javascripts/editor.js index e650a0e8..eef8f7d4 100644 --- a/app/assets/javascripts/editor.js +++ b/app/assets/javascripts/editor.js @@ -617,32 +617,27 @@ $(function() { showRequestedTab(); } - var stderrOutput = ''; var handleStderrOutputForFlowr = function(event) { var flowrUrl = $('#flowrHint').data('url'); var json = JSON.parse(event.data); + var stderrOutput = ''; if (json.stderr) { stderrOutput += json.stderr; } else if (json.code) { var flowrHintBody = $('#flowrHint .panel-body'); - jQuery.getJSON(flowrUrl + '&query=' + escape(stderrOutput), function(data) { - for (var question in data.queryResults) { - // replace everything, not only one occurence - var collapsibleTileHtml = flowrResultHtml.replace(/{{collapseId}}/g, 'collapse-' + question).replace(/{{headingId}}/g, 'heading-' + question); + $.getJSON(flowrUrl + '&query=' + escape(stderrOutput), function(data) { + _.each(_.compact(data.queryResults), function(question, index) { + var collapsibleTileHtml = flowrResultHtml.replace(/{{collapseId}}/g, 'collapse-' + index).replace(/{{headingId}}/g, 'heading-' + index); var resultTile = $(collapsibleTileHtml); - - resultTile.find('h4 > a').text(data.queryResults[question].title); - resultTile.find('.panel-body').append($(data.queryResults[question].body)); - + resultTile.find('h4 > a').text(question.title); + resultTile.find('.panel-body').append(question.body); flowrHintBody.append(resultTile); - } + }); $('#flowrHint').fadeIn(); }); - - stderrOutput = ''; } }; });