From 652f3fefcb3e863645ba8b4b503d13168c0258aa Mon Sep 17 00:00:00 2001
From: Sebastian Serth <Sebastian.Serth@hpi.de>
Date: Tue, 19 Sep 2023 15:38:25 +0200
Subject: [PATCH] Transform data privacy link from locales to view

Amends #1899
---
 app/views/exercises/implement.html.slim | 3 ++-
 config/locales/de.yml                   | 4 ++--
 config/locales/en.yml                   | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/app/views/exercises/implement.html.slim b/app/views/exercises/implement.html.slim
index f38a23fc..40a7c0eb 100644
--- a/app/views/exercises/implement.html.slim
+++ b/app/views/exercises/implement.html.slim
@@ -20,7 +20,8 @@
                 = t('exercises.editor.start_video')
 
               div.small.text-body-tertiary.text-nowrap.mt-1
-                == t('exercises.implement.external_privacy_policy', url: 'https://www.tu-ilmenau.de/datenschutz')
+                a href='https://www.tu-ilmenau.de/datenschutz' target='_blank' rel='noopener'
+                  = t('exercises.implement.external_privacy_policy')
 
             span.me-3.mt-1
               button.btn.btn-sm.btn-secondary.text-nowrap#info data-bs-toggle= 'modal' data-bs-target= '#modal-info-pair-programming'
diff --git a/config/locales/de.yml b/config/locales/de.yml
index 812f6756..df76b2ed 100644
--- a/config/locales/de.yml
+++ b/config/locales/de.yml
@@ -403,7 +403,7 @@ de:
       send: Senden
       start_over: Diese Aufgabe zurücksetzen
       start_over_active_file: Diese Datei zurücksetzen
-      start_video: (Video) Chat starten
+      start_video: (Video-) Chat starten
       stop: Stoppen
       submit: Code zur Bewertung abgeben
       deadline: Deadline
@@ -473,7 +473,7 @@ de:
       default_linter_feedback: Sehr gut. Der Linter hat nichts mehr zu beanstanden.
       error_messages: Fehlermeldungen
       existing_programming_group: Sie arbeiten gerade an der Übung mit dem Titel '%{exercise}' als Teil einer Programmiergruppe. Bitte schließen Sie Ihre Arbeit dort ab, indem Sie Ihren Code bewerten und abgeben, bevor Sie mit der Bearbeitung dieser Übung beginnen.
-      external_privacy_policy: "<a href=%{url}>Datenschutzerklärung</a>"
+      external_privacy_policy: Datenschutzerklärung
       messages: Meldungen
       feedback: Feedback
       test_file: 'Test-Datei <span class="number">%{number}</span> (<span class="filename">%{filename}</span>)'
diff --git a/config/locales/en.yml b/config/locales/en.yml
index 82d98d2d..b4d9991b 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -473,7 +473,7 @@ en:
       default_linter_feedback: Well done. The linter is completly satisfied.
       error_messages: Error Messages
       existing_programming_group: You are currently working on the exercise entitled '%{exercise}' as part of a programming group. Please finish your work there by scoring and submitting your code before you start implementing this exercise.
-      external_privacy_policy: "<a href=%{url}>privacy policy</a>"
+      external_privacy_policy: privacy policy
       messages: Messages
       feedback: Feedback
       test_file: 'Test File <span class="number">%{number}</span> (<span class="filename">%{filename}</span>)'