fix exercise_file duplication bug

2019-10-07 18:50:07 +02:00
parent 49d438cef8
commit 6a296cbe65
5 changed files with 19 additions and 11 deletions
--- a/app/services/proforma_service/import.rb
+++ b/app/services/proforma_service/import.rb
@ -11,8 +11,12 @@ module ProformaService
      if single_task?
        importer = Proforma::Importer.new(@zip)
        @task = importer.perform
-        exercise = ConvertTaskToExercise.call(task: @task, user: @user)
-        exercise.save!
+
+        exercise = Exercise.find_by(uuid: @task.uuid)
+        exercise_files = exercise&.files&.to_a
+
+        exercise = ConvertTaskToExercise.call(task: @task, user: @user, exercise: exercise)
+        exercise_files&.each(&:destroy) # feels suboptimal

        exercise
      else