From 6ecaa559fb82b643ac0e4ccf4599720ce19f0464 Mon Sep 17 00:00:00 2001
From: Ralf Teusner <ralf.teusner@hpi.uni-potsdam.de>
Date: Thu, 23 Apr 2015 16:29:34 +0200
Subject: [PATCH] some readability improvement of score checks

---
 app/models/submission.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/models/submission.rb b/app/models/submission.rb
index b8667e68..ea72fe17 100644
--- a/app/models/submission.rb
+++ b/app/models/submission.rb
@@ -38,7 +38,7 @@ class Submission < ActiveRecord::Base
   end
 
   def normalized_score
-    if score && exercise.maximum_score && exercise.maximum_score > 0
+    if !score.nil? && !exercise.maximum_score.nil? && (exercise.maximum_score > 0)
       score / exercise.maximum_score
     else
       0