htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use BigDecimals for score calculations

Browse Source
This commit is contained in:
Sebastian Serth
2021-12-16 23:12:16 +01:00
parent 416135daf0
commit 79edace57b
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/models/submission.rb
View File

@ -291,7 +291,8 @@ class Submission < ApplicationRecord
score += output[:score] * output[:weight] unless output.nil? score += output[:score] * output[:weight] unless output.nil?
end end
end end
update(score: score) # Prevent floating point precision issues by converting to BigDecimal, e.g., for `0.28 * 25`
update(score: score.to_d)
if normalized_score.to_d == 1.0.to_d if normalized_score.to_d == 1.0.to_d
Thread.new do Thread.new do
RequestForComment.where(exercise_id: exercise_id, user_id: user_id, user_type: user_type).find_each do |rfc| RequestForComment.where(exercise_id: exercise_id, user_id: user_id, user_type: user_type).find_each do |rfc|