From 5c4ea86c8ea368b3f3a3c9fdfd76d28551bd35ba Mon Sep 17 00:00:00 2001 From: Maximilian Grundke Date: Fri, 25 May 2018 09:59:50 +0200 Subject: [PATCH] Fix finishing rate for zero users/submissions --- app/views/exercises/statistics.html.slim | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/views/exercises/statistics.html.slim b/app/views/exercises/statistics.html.slim index 6d967885..211cc862 100644 --- a/app/views/exercises/statistics.html.slim +++ b/app/views/exercises/statistics.html.slim @@ -9,7 +9,9 @@ h1 = @exercise = row(label: '.finishing_rate') do p == @exercise.finishers.count ? "#{t('shared.out_of', maximum_value: @exercise.users.distinct.count, value: @exercise.finishers.count)} #{t('exercises.statistics.external_users')}" : empty - p = progress_bar((100.0 / @exercise.users.distinct.count * @exercise.finishers.count).round(2)) + - finishers_count = @exercise.users.distinct.count + - finishers_percentage = finishers_count == 0 ? 0 : (100.0 / finishers_count * @exercise.finishers.count).round(2) + p = progress_bar(finishers_percentage) = row(label: '.average_score') do p == @exercise.average_score ? t('shared.out_of', maximum_value: @exercise.maximum_score, value: @exercise.average_score.round(2)) : empty