Group statistics per user type

app/models/exercise.rb

@@ -11,7 +11,10 @@ class Exercise < ActiveRecord::Base
   belongs_to :execution_environment
   has_many :submissions
   belongs_to :team
-  has_many :users, source_type: ExternalUser, through: :submissions
+
+  has_many :external_users, source: :user, source_type: ExternalUser, through: :submissions
+  has_many :internal_users, source: :user, source_type: InternalUser, through: :submissions
+  alias_method :users, :external_users
 
   scope :with_submissions, -> { where('id IN (SELECT exercise_id FROM submissions)') }
 
@@ -22,6 +25,7 @@ class Exercise < ActiveRecord::Base
   validates :title, presence: true
   validates :token, presence: true, uniqueness: true
 
+
   def average_percentage
     (average_score / maximum_score * 100).round if average_score
   end

app/views/exercises/statistics.html.slim

@@ -8,18 +8,20 @@ h1 = @exercise
   p == @exercise.average_score ? t('shared.out_of', maximum_value: @exercise.maximum_score, value: @exercise.average_score.round(2)) : empty
   p = progress_bar(@exercise.average_percentage)
 
-.table-responsive
-  table.table
-    thead
-      tr
-        - ['.user', '.score', '.runs', '.worktime'].each do |title|
-          th.header = t(title)
-    tbody
-      - @exercise.users.distinct().each do |user|
+- Hash[:internal_users => t('.internal_users'), :external_users => t('.external_users')].each_pair do |symbol, label|
+  strong = label
+  .table-responsive
+    table.table
+      thead
         tr
-          - submissions = @exercise.submissions.where('user_id=?', user.id)
-          td = "#{user.name} (#{user.email})"
-          td = submissions.maximum('score')
-          td = submissions.count('id')
-          - seconds = submissions.maximum('created_at') - submissions.minimum('created_at')
-          td = "#{distance_of_time_in_words(seconds)} (#{seconds})"
+          - ['.user', '.score', '.runs', '.worktime'].each do |title|
+            th.header = t(title)
+      tbody
+        - @exercise.send(symbol).distinct().each do |user|
+          tr
+            - submissions = @exercise.submissions.where('user_id=?', user.id)
+            td = "#{user.name} (#{user.email})"
+            td = submissions.maximum('score')
+            td = submissions.count('id')
+            - seconds = submissions.maximum('created_at') - submissions.minimum('created_at')
+            td = "#{distance_of_time_in_words(seconds)} (#{seconds})"