Update Bootstrap to v4.1, fix chosen.js and pagedown on multiple sites

app/views/request_for_comments/_admin_menu.html.slim

@@ -1,9 +1,8 @@
-br
-h4 Admin Menu
-h5
-  ul
-    li = link_to "User's current status of this exercise", statistics_external_user_exercise_path(id: @request_for_comment.exercise_id, external_user_id: @request_for_comment.user_id)
-    li = link_to "All exercises of this user", statistics_external_user_path(id: @request_for_comment.user_id)
-  ul
-    li = link_to "Implement the exercise yourself", implement_exercise_path(id: @request_for_comment.exercise_id)
-    li = link_to "Show the exercise", exercise_path(id: @request_for_comment.exercise_id)
+hr
+h5.mt-4 Admin Menu
+ul.text
+  li = link_to "User's current status of this exercise", statistics_external_user_exercise_path(id: @request_for_comment.exercise_id, external_user_id: @request_for_comment.user_id)
+  li = link_to "All exercises of this user", statistics_external_user_path(id: @request_for_comment.user_id)
+ul.text
+  li = link_to "Implement the exercise yourself", implement_exercise_path(id: @request_for_comment.exercise_id)
+  li = link_to "Show the exercise", exercise_path(id: @request_for_comment.exercise_id)

app/views/request_for_comments/_mark_as_solved.html.slim

@@ -4,4 +4,4 @@ button.btn.btn-primary#mark-as-solved-button = t('request_for_comments.mark_as_s
   p = t('request_for_comments.write_a_thank_you_node')
   textarea#thank-you-note
   button.btn.btn-primary#send-thank-you-note = t('request_for_comments.send_thank_you_note')
-  button.btn.btn-default#cancel-thank-you-note = t('request_for_comments.cancel_thank_you_note')
+  button.btn.btn-secondary#cancel-thank-you-note = t('request_for_comments.cancel_thank_you_note')

app/views/request_for_comments/index.html.slim

@@ -9,7 +9,7 @@ h1 = RequestForComment.model_name.human(count: 2)
     = f.select(:solved_not_eq,  [[t('request_for_comments.show_all'), 2], [t('request_for_comments.show_unsolved'), 1], [t('request_for_comments.show_solved'), 0]])
 
 .table-responsive
-  table.table.sortable
+  table.table.sortable.mt-4
     thead
       tr
         th
@@ -39,7 +39,7 @@ h1 = RequestForComment.model_name.human(count: 2)
           - else
             td = '-'
           td = request_for_comment.comments_count
-          td = request_for_comment.user.displayname
+          td = link_to_if(request_for_comment.user && policy(request_for_comment.user).show?, request_for_comment.user.displayname, request_for_comment.user)
           td = t('shared.time.before', time: distance_of_time_in_words_to_now(request_for_comment.created_at))
           td = t('shared.time.before', time: distance_of_time_in_words_to_now(request_for_comment.last_comment.nil? ? request_for_comment.updated_at : request_for_comment.last_comment))
 

app/views/request_for_comments/show.html.erb

@@ -25,7 +25,7 @@
     </div>
 
     <div class="question">
-      <h5>
+      <h5 class="mt-4">
         <%= t('activerecord.attributes.request_for_comments.question')%>
       </h5>
       <div class="text">
@@ -42,7 +42,7 @@
       <div class="testruns">
         <% output_runs = testruns.select { |run| run.cause == 'run' } %>
         <% if output_runs.size > 0 %>
-          <h5><%= t('request_for_comments.runtime_output') %></h5>
+          <h5 class="mt-4"><%= t('request_for_comments.runtime_output') %></h5>
           <div class="collapsed testrun-output text">
             <span class="fa fa-chevron-down collapse-button"></span>
             <% output_runs.each do |testrun| %>
@@ -63,7 +63,7 @@
 
         <% assess_runs = testruns.select { |run| run.cause == 'assess' } %>
         <% if assess_runs.size > 0 %>
-          <h5><%= t('request_for_comments.test_results') %></h5>
+          <h5 class="mt-4"><%= t('request_for_comments.test_results') %></h5>
           <div class="testrun-assess-results">
             <% assess_runs.each do |testrun| %>
               <div class="testrun-container">
@@ -86,7 +86,7 @@
     <hr>
 
     <div class="howto">
-      <h5>
+      <h5 class="mt-4">
         <%= t('request_for_comments.howto_title') %>
       </h5>
       <div class="text">
@@ -96,7 +96,7 @@
   </div>
 </div>
 
-<div class="hidden sanitizer"></div>
+<div class="d-none sanitizer"></div>
 <!--
 do not put a carriage return in the line below. it will be present in the presentation of the source code, otherwise.
 also, all settings from the rails model needed for the editor configuration in the JavaScript are attached to the editor as data attributes here.
@@ -205,16 +205,16 @@ also, all settings from the rails model needed for the editor configuration in t
           <div class="comment-header"> \
             <div class="comment-username">' + preprocess(comment.username) + '</div> \
             <div class="comment-date">' + comment.date + '</div> \
-            <div class="comment-updated' + (comment.updated ? '' : ' hidden') + '"> \
+            <div class="comment-updated' + (comment.updated ? '' : ' d-none') + '"> \
               <i class="fa fa-pencil" aria-hidden="true"></i> \
               <%= t('request_for_comments.comment_edited') %> \
             </div> \
           </div> \
           <div class="comment-content">' + commentText + '</div> \
           <textarea class="comment-editor">' + commentText + '</textarea> \
-          <div class="comment-actions' + (comment.editable ? '' : ' hidden') + '"> \
-            <button class="action-edit btn btn-xs btn-warning"><%= t('shared.edit') %></button> \
-            <button class="action-delete btn btn-xs btn-danger"><%= t('shared.destroy') %></button> \
+          <div class="comment-actions' + (comment.editable ? '' : ' d-none') + '"> \
+            <button class="action-edit btn btn-sm btn-warning"><%= t('shared.edit') %></button> \
+            <button class="action-delete btn btn-sm btn-danger"><%= t('shared.destroy') %></button> \
           </div> \
         </div>';
     });
@@ -380,7 +380,7 @@ also, all settings from the rails model needed for the editor configuration in t
     $(target).popover('show');
     $(target).on('mouseleave', function () {
       $(this).off('mouseleave');
-      $(this).popover('destroy');
+      $(this).popover('dispose');
     });
   }
 
@@ -440,7 +440,7 @@ also, all settings from the rails model needed for the editor configuration in t
             deleteButton.show();
             commentContent.show();
             commentEditor.hide();
-            commentUpdated.removeClass('hidden');
+            commentUpdated.removeClass('d-none');
           });
         } else {
           button.text('<%= t('comments.save_update') %>');